Make build-and-test-on-freebsd fail if steps do not complete successfully #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleGrumpy
force-pushed
the
test-on-freebsd
branch
6 times, most recently
from
66f9d97 to
7a6ec8a
Compare
|
this will fail on main (uf2tool doesn't pick up the rebar3 install), if you add
|
Thanks for the heads up on that! This is a better solution anyway, as the rebar3 version will stay in sync with the distro OTP version. |
…ully This workflow is a different from most in that the entire build and test is done in a single script in a FreeBSB QEMU constainer on an Ubuntu host. Because it is one large shell script, with no separate "jobs", exits needed to be added to ensure the test fails if any important steps fail to complete successfully. Adds missing rebar3 installation required to complete the tests build. Signed-off-by: Winford <[email protected]>
Update the Ubuntu host OS that QEMU runs FreeBSD hosts on to Ubuntu 24.04. Changes the workflow to a matrix build against the current stable release of FreeBSD, as well as the latest legacy release update. Signed-off-by: Winford <[email protected]>
UncleGrumpy
force-pushed
the
test-on-freebsd
branch
from
7a6ec8a to
29e3c9b
Compare
|
The test failures on FreeBSD has revealed a bug in our http_server, as @pguyot explained to me in the Telegram chat. |
petermm
approved these changes
Jan 19, 2025
UncleGrumpy
changed the title
bettio
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Ubuntu host to 24.04, and changes to as matrix build with the current stable (14.2) and latest legacy release update (13.4) versions of FreeBSD.
This workflow is a different from most in that the entire build and test is done in a single script in a FreeBSB container on an Ubuntu host. Because it is one large shell script with no separate "jobs" exits needed to be added to ensure the test fails if any important steps fail to complete successfully.
Adds missing rebar3 installation required to complete the tests build.
Closes #1435
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later