-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: ESP32 Performance & Power #1481
Conversation
7cc29d1
to
b0fbbfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this information makes more sense to include as an addendum to the Build Instructions section of the docs.
49e5ea4
to
f122f46
Compare
Moved it to |
f122f46
to
4041e71
Compare
Sorry I missed the triple backticks the first time I looked through this ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed the backticks the first time through.
4041e71
to
b3baf76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a great addition to the documentation. Thanks for helping fill in some of the gaps!
b3baf76
to
6f15766
Compare
Docs for changing performance/power menuconfig on Esp32. Signed-off-by: Peter M <[email protected]>
6f15766
to
aa5179a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good so far, but I'm not sure If we should add more details to the basic build instructions, rather than adding a page about tuning esp32 build.
I do see your point, this may not be enough information to break out into a separate chapter yet, but it might be better to push these added customizations further down past the default build and flash instructions. A good place would be right before the section for adding custom nifs and ports to an image. |
On second thought, if we do start a guide for tuning the build it might attract more contributions, and could also include a section for building debug builds, and enabling the static code checker. |
Let's refactor documentation on a second step, I will merge this first step that is still a good contribution. |
Docs for changing performance/power menuconfig on Esp32.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later