Fix network.erl race conditions #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleGrumpy
approved these changes
Jan 22, 2025
pguyot
reviewed
Jan 23, 2025
pguyot
reviewed
Jan 23, 2025
src/platforms/esp32/test/main/test_erl_sources/test_wifi_example.erl
Outdated
Show resolved
Hide resolved
petermm
force-pushed
the
fix-network-races
branch
2 times, most recently
from
b51790d to
03dab59
Compare
pguyot
reviewed
Jan 23, 2025
|
This should be good to go. Of note there was an additional crash as sta_rssi() is unsafe to call before connection is made, and calling it instantly after network:start would driver crash (port is up but network is not connected) - thus extra guard in the driver. I fully understand that some supervisor should be introduced, and some contract decided upon eg. if network port ever disappears unexpected, or doesn't shutdown, exit and restart should happen?. But this a bugfix PR against release-0.6. After this one we can look at making 0.7 beautiful;-) |
bettio
reviewed
Feb 10, 2025
Cleaner, DRY code - and avoid any potential races. Signed-off-by: Peter M <[email protected]>
Calling network:sta_rssi() would crash if network was not started. And just if network_port was started but not connected yet. Handle this and return error tuple, and added tests for both scenarios. Signed-off-by: Peter M <[email protected]>
network:stop through terminate was using nonblocking call to stop network_port- so rapid stop/start would give the second network:start an old whereis(network_port) that was still shutting down, and lead to errors. Now waits for port DOWN. Signed-off-by: Peter M <[email protected]>
petermm
force-pushed
the
fix-network-races
branch
from
03dab59 to
6920c66
Compare
bettio
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As evidenced by failing simtest CI on release-0.6 etc.
startup should use continue/handle_continue and avoid races + cleaner DRY code.
network:stop was using nonblocking call to stop network_port- so rapid stop/start would give the last network:start an old whereis(network_port) that was still shutting down, and lead to errors.
somewhat unrelated: sta_rssi was using get_port(), and would crash on no network started - guarded it erlang side, added test.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later