Fix network.erl race conditions #1487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaner, DRY code - and avoid any potential races. Signed-off-by: Peter M <[email protected]>
network:stop through terminate was using nonblocking call to stop network_port- so rapid stop/start would give the second network:start an old whereis(network_port) that was still shutting down, and lead to errors. Now waits for port DOWN. Signed-off-by: Peter M <[email protected]>
Calling network:sta_rssi() would crash if network was not started. Handle this and return error tuple, and added test. Signed-off-by: Peter M <[email protected]>
arpunk
reviewed
Jan 22, 2025
| % Handle unexpected messages if necessary | ||
| wait_for_port_close(PortMonitor, Pid) | ||
| % Timeout after 4000 milliseconds | ||
| after 4000 -> |
There was a problem hiding this comment.
You might want to be able to pass the timeout as an option at startup and default to 4_000 if not provided.
UncleGrumpy
approved these changes
Jan 22, 2025
pguyot
reviewed
Jan 23, 2025
| Ref = make_ref(), | ||
| Pid = State#state.port, |
There was a problem hiding this comment.
Let's call it Port ;-)
Also, the monitor could be set up in init/1 and used as Ref in #state.
pguyot
reviewed
Jan 23, 2025
| @@ -25,6 +25,7 @@ | |||
| start() -> | |||
| case verify_platform(atomvm:platform()) of | |||
| ok -> | |||
| network:sta_rssi(), | |||
There was a problem hiding this comment.
Should we assert (match) the result?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As evidenced by failing simtest CI on release-0.6 etc.
startup should use continue/handle_continue and avoid races + cleaner DRY code.
network:stop was using nonblocking call to stop network_port- so rapid stop/start would give the last network:start an old whereis(network_port) that was still shutting down, and lead to errors.
somewhat unrelated: sta_rssi was using get_port(), and would crash on no network started - guarded it erlang side, added test.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later