-
Notifications
You must be signed in to change notification settings - Fork 121
Fix fail label logic with bs_create_bin #1731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-0.6
Are you sure you want to change the base?
Conversation
caf7f0c
to
87de5d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FreeBSD in a quite odd way.
Let's investigate it before merging this PR.
The error seems to be: sh: ./src/AtomV: not found |
I don’t know if this most recent FreeBSD failure is related to using ninja, but here logs reports “Packing archive test_estdlib_lib.avm” but line 125 of build-and-test-on-FreeBSD.yml tries to execute |
It looks like one of the yaml file is getting truncated:
In case we find a fix of this, let's do that on a separated commit |
I think run script is getting truncated somehow at around 1003 characters. Anyway I opened an issue here: |
I meant to remove part of this PR changes to see if this truncation still happens. Will try to do that tonight or this weekend. |
Also simplify bs_create_bin Add tests for bs_create_bin using Erlang assembly Signed-off-by: Paul Guyot <[email protected]>
dd93eed
to
87d37bd
Compare
…ncated Signed-off-by: Paul Guyot <[email protected]>
9a58aed
to
b12b17f
Compare
Also simplify bs_create_bin
Add tests for bs_create_bin using Erlang assembly
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later