Skip to content

Move and rename several functions out of opcodeswitch #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pguyot
Copy link
Collaborator

@pguyot pguyot commented Jul 6, 2025

Move and rename dump to context_dump
Factorize and rename cp_to_mod_lbl_off to module_cp_to_label_offset
Move and rename get_catch_label_and_change_module to context_get_catch_label

These functions are used by native code

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

@pguyot pguyot force-pushed the w27/move-context-functions-out-of-opcodeswitch branch from b864cf5 to fca649f Compare July 6, 2025 07:54
@pguyot pguyot changed the title Move and rename dump to context_dump, factorize and rename cp_to_mod_lbl_off Move and rename several functions out of opcodeswitch Jul 6, 2025
Copy link
Collaborator

@bettio bettio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few minor comments here.

@pguyot pguyot force-pushed the w27/move-context-functions-out-of-opcodeswitch branch 2 times, most recently from 7e166b4 to 5a88286 Compare July 6, 2025 14:30
Move and rename dump to context_dump
Factorize and rename cp_to_mod_lbl_off to module_cp_to_label_offset
Move and rename get_catch_label_and_change_module to context_get_catch_label

Signed-off-by: Paul Guyot <[email protected]>
@pguyot pguyot force-pushed the w27/move-context-functions-out-of-opcodeswitch branch from 5a88286 to 09f7d94 Compare July 6, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants