Fix race condition in sys_poll_events_with_poll on unix
#2043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure `listeners_poll_count` and `select_events_poll_count` are only updated with locks acquired. This avoids a race condition where `listeners_poll_count` would be marked clean while it was marked dirty with `sys_register_listener` at the same time. It could explain some timeout issues with tests. Signed-off-by: Paul Guyot <[email protected]>
bettio
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
listeners_poll_countandselect_events_poll_countare only updated with locks acquired. This avoids a race condition wherelisteners_poll_countwould be marked clean while it was marked dirty withsys_register_listenerat the same time. It could explain some timeout issues with tests.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later