Skip to content

fix: build warnings and Clippy issues on Windows #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025

Conversation

ltrzesniewski
Copy link
Contributor

@ltrzesniewski ltrzesniewski commented Aug 3, 2025

This fixes a few build warnings and issues reported by Clippy on Windows.

This is essentially the second commit of #2714, updated with a few new lints.

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@ltrzesniewski ltrzesniewski changed the title fix: clippy issues on Windows fix: build warnings and Clippy issues on Windows Aug 3, 2025
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!!

@ellie ellie merged commit 6d49fdb into atuinsh:main Aug 4, 2025
19 checks passed
@ltrzesniewski ltrzesniewski deleted the clippy-windows branch August 4, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants