Convert EXPECT_STREQ to matcher syntax #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiphogg
approved these changes
May 9, 2025
| using ::testing::StrEq; | ||
|
|
||
| namespace detail { | ||
|
|
||
| TEST(StringConstant, CanCreateFromStringLiteral) { | ||
| constexpr StringConstant<5> x{"hello"}; | ||
| EXPECT_STREQ(x.c_str(), "hello"); |
There was a problem hiding this comment.
I didn't realize we could get rid of these c_str() calls. Neat! I wonder if we needed them with EXPECT_STREQ, and if not, then I wonder why I added them in the first place.
There was a problem hiding this comment.
I'm not sure I tried it. I do know the matcher certainly provided better ability to match different types, so I just tried it and it worked!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts existing uses of
EXPECT_STREQto use theStrEqandIsEmptymatchers. Note that we really want to test the
StringContstant's ability todo string things. If we want to test the behavior of
c_str, that should be aspecific test.
Partial implementation for #404.