Rename detail namespace to auimpl
#427
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think a "bite the bullet megadiff" makes the most sense here, because the changes should all be the same length, so the PR should be fairly easy to review. The reviewer can check the Viewed box for one file at a time, and thus not be forced to do it all in one pass --- as long as we do end up landing this relatively soon before we try other changes.
chiphogg
commented
May 10, 2025
| detail::OrderByOrigin, | ||
| detail::OrderAsUnitProduct, | ||
| detail::OrderAsOriginDisplacementUnit> {}; | ||
| auimpl::OrderByUnitAvoidance, |
There was a problem hiding this comment.
I think I'm going to skip doing this for now, because au::detail::UnitAvoidance is actually in our public facing documentation. We'll need to give folks a migration path away from naming the detail namespace before we change its name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think a "bite the bullet megadiff" makes the most sense here, because
the changes should all be the same length, so the PR should be fairly
easy to review. The reviewer can check the Viewed box for one file at a
time, and thus not be forced to do it all in one pass --- as long as we
do end up landing this relatively soon before we try other changes.
Fixes #412.