fix: read and migrate v3 session format to v4#1923
Merged
arpit-jn merged 3 commits intoauth0:mainfrom Feb 18, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1923 +/- ##
==========================================
+ Coverage 74.69% 76.06% +1.37%
==========================================
Files 19 20 +1
Lines 1379 1496 +117
Branches 210 233 +23
==========================================
+ Hits 1030 1138 +108
- Misses 342 351 +9
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nandan-bhat
approved these changes
Feb 18, 2025
arpit-jn
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Changes
When migrating from v3 to v4 of the SDK, the session format and cookie names differ. This results in the SDK not recognizing that the user has a session and treating them as logged-out.
This PR adds support for reading the v3 session format in both stateless and stateful modes and normalizes them to the v4 format. This ensures that users with existing sessions will be respected in v4.
📎 References
🎯 Testing