-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support message thread and thread member APIs #34
Conversation
cli/.env-default
Outdated
@@ -0,0 +1,4 @@ | |||
ELATION_BASE_URL=https://app.elationemr.com/api/2.0/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have the default vars point to the sandbox env?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, can do.
return err | ||
} | ||
|
||
spew.Dump(response) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spew.Dump call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's on purpose. I don't want to write formatters for every response type.
@@ -0,0 +1,23 @@ | |||
module github.com/authorhealth/go-elation/cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this needs to be a separate module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. My thinking was by keeping this as a separate module, it avoided making consumers of the client pull in the CLI-specific dependencies like cobra and spew.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's OK for now - maybe revisit when we feel the need to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably my lack of go-fu, but I'm getting import cycles trying to move this out of the separate package. I'm going to leave this as-is, but if you know a way to resolve this cycles, I'd be happy to refactor.
Read-only APIs for message threads and thread members.
Also adds the beginnings of a CLI tool for testing the API.