Extend Create Appointment request #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliehastings
force-pushed
the
extend-create-appt-request
branch
from
0443105 to
be3f7a5
Compare
gffking
approved these changes
Jun 20, 2024
| @@ -40,11 +40,14 @@ type AppointmentService struct { | |||
| } | |||
|
|
|||
| type AppointmentCreate struct { | |||
There was a problem hiding this comment.
Just to confirm, the API works as expected when sending an explicit null value for description and service_location?
There was a problem hiding this comment.
Yep, that creates an appointment with an empty string description and a nil service_location in the response back 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Description,Duration, andServiceLocationto the Create Appointment request per the Elation API docsElation documents
Durationas an optional field but it does appear to be required based on API errors returned when left missing/null -{"duration":["This field may not be null."]}