Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-688 # Propagate exceptions from java api operations #690

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

javiertuya
Copy link
Collaborator

@javiertuya javiertuya commented Oct 20, 2024

Propagate exceptions from java api operations

Fixes Issue

PR Branch
https://github.com/javiertuya/zerocode/tree/688-exceptions-java-api

Motivation and Context

When executing a java method that is invoked by the java api as an operation, any exception in the java method should be shown in the stacktrace to facilitate debugging. The executor exception handler should include this exception

Checklist:

  • New Unit tests were added

    • Covered in existing Unit tests
  • Integration tests were added

    • Covered in existing Integration tests
  • Test names are meaningful

  • Feature manually tested and outcome is successful

  • PR doesn't break any of the earlier features for end users

    • WARNING! This might break one or more earlier earlier features, hence left a comment tagging all reviewrs
  • Branch build passed in CI

  • No 'package.*' in the imports

  • Relevant DOcumentation page added or updated with clear instructions and examples for the end user

    • Not applicable. This was only a code refactor change, no functional or behaviourial changes were introduced
  • Http test added to http-testing module(if applicable) ?

    • Not applicable. The changes did not affect HTTP automation flow
  • Kafka test added to kafka-testing module(if applicable) ?

    • Not applicable. The changes did not affect Kafka automation flow

@javiertuya
Copy link
Collaborator Author

@authorjapps Now that I've collaborator access, I have a few questions about the PR workflow on this repo:

  • Should I merge PRs submitted by me once they get the approval (like this), or let the reviewers do it?
  • Just after I create a PR, should I assign you as reviewer, place a mention or nothing?

@authorjapps
Copy link
Owner

@authorjapps Now that I've collaborator access, I have a few questions about the PR workflow on this repo:

  • Should I merge PRs submitted by me once they get the approval (like this), or let the reviewers do it?
  • Just after I create a PR, should I assign you as reviewer, place a mention or nothing?

@javiertuya, Thanks for asking.
You can merge it, if nothing is outstanding from any reviewers.

In this case, yes, go ahead and merge it 👍
and then, just watch the master build to go Green automatically.

@javiertuya javiertuya merged commit 9be3dba into authorjapps:master Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions thrown from classes executed by the java api are not propagated
2 participants