test: add tests for migrate command #2822
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/cli
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (74.44%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2822 +/- ##
==========================================
- Coverage 78.46% 74.44% -4.01%
==========================================
Files 459 484 +25
Lines 44674 57303 +12629
==========================================
+ Hits 35048 42656 +7608
- Misses 6769 11657 +4888
- Partials 2857 2990 +133 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add test cases for all error paths in executeMigrate: - CockroachDB driver creation failure (invalid URI) - Postgres invalid credentials provider - Postgres driver creation failure (invalid URI) - Spanner driver creation failure (cancelled context) - MySQL invalid credentials provider - MySQL driver creation failure (invalid DSN)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2758 by refactoring migrate execution for testability and adding coverage.
Changes