Skip to content

Conversation

@miparnisari
Copy link
Contributor

@miparnisari miparnisari commented Jan 30, 2026

Description

Avoid having to store each individual configuration for Watch API inside every datastore implementation.

Important files to review:

  • pkg/datastore/datastore.go

Testing

References

Closes #2861

@github-actions github-actions bot added area/cli Affects the command line area/api v1 Affects the v1 API area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Jan 30, 2026
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 84.37500% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.39%. Comparing base (0ab9618) to head (5809bb1).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/datastore/datastore.go 64.87% 24 Missing and 2 partials ⚠️
...nal/datastore/proxy/schemacaching/watchingcache.go 64.71% 5 Missing and 1 partial ⚠️
internal/services/v1/watch.go 82.36% 2 Missing and 1 partial ⚠️
internal/datastore/proxy/counting.go 0.00% 2 Missing ⚠️
internal/datastore/proxy/singleflight.go 0.00% 2 Missing ⚠️
pkg/cmd/testserver/testserver.go 0.00% 1 Missing ⚠️

❌ Your project check has failed because the head coverage (74.39%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2867      +/-   ##
==========================================
- Coverage   74.44%   74.39%   -0.04%     
==========================================
  Files         484      484              
  Lines       57702    57730      +28     
==========================================
- Hits        42948    42942       -6     
- Misses      11744    11779      +35     
+ Partials     3010     3009       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@miparnisari miparnisari force-pushed the refactor-watch-flags branch 2 times, most recently from 54a3240 to cf1ba27 Compare February 2, 2026 00:42
@miparnisari miparnisari changed the title chore: refactor Watch API flags (close #2861) chore: refactor Watch API flags Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api v1 Affects the v1 API area/cli Affects the command line area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor passing down of watch flags to avoid bugs

2 participants