-
Notifications
You must be signed in to change notification settings - Fork 366
fix: improve LR consistency and support multiple resourcetypes #2875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (74.38%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2875 +/- ##
==========================================
- Coverage 74.40% 74.38% -0.02%
==========================================
Files 484 484
Lines 57786 57827 +41
==========================================
+ Hits 42989 43006 +17
- Misses 11787 11798 +11
- Partials 3010 3023 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tstirrat15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see comments
| } | ||
|
|
||
| // Build a set of types that appear in ALL sub-iterators | ||
| result := mapz.NewSet[ObjectType]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
result := mapz.NewSet[ObjectType](firstTypes...)
I would have done this as a suggestion but the github review UI is awful.
| return nil, err | ||
| } | ||
|
|
||
| subSet := mapz.NewSet[ObjectType]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Description
Testing
References