Skip to content

Conversation

@barakmich
Copy link
Contributor

Description

Testing

References

@barakmich barakmich requested a review from a team as a code owner February 3, 2026 21:36
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Feb 3, 2026
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 68.81720% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.38%. Comparing base (ea09c1e) to head (a772763).

Files with missing lines Patch % Lines
pkg/query/intersection.go 54.84% 10 Missing and 4 partials ⚠️
pkg/query/alias.go 46.67% 6 Missing and 2 partials ⚠️
pkg/query/datastore.go 57.15% 3 Missing ⚠️
pkg/query/self.go 76.93% 2 Missing and 1 partial ⚠️
pkg/query/union.go 87.50% 1 Missing ⚠️

❌ Your project check has failed because the head coverage (74.38%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2875      +/-   ##
==========================================
- Coverage   74.40%   74.38%   -0.02%     
==========================================
  Files         484      484              
  Lines       57786    57827      +41     
==========================================
+ Hits        42989    43006      +17     
- Misses      11787    11798      +11     
- Partials     3010     3023      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see comments

}

// Build a set of types that appear in ALL sub-iterators
result := mapz.NewSet[ObjectType]()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

	result := mapz.NewSet[ObjectType](firstTypes...)

I would have done this as a suggestion but the github review UI is awful.

return nil, err
}

subSet := mapz.NewSet[ObjectType]()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants