Skip to content

feat: add Docker image publishing to GHCR #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

s0up4200
Copy link
Contributor

No description provided.

@s0up4200 s0up4200 changed the title feat: add Docker image publishing to GHCR (#71) feat: add Docker image publishing to GHCR Jul 21, 2025
@s0up4200 s0up4200 added enhancement New feature or request build labels Jul 21, 2025
@s0up4200
Copy link
Contributor Author

#71

@s0up4200 s0up4200 linked an issue Jul 21, 2025 that may be closed by this pull request
s0up4200 and others added 3 commits July 22, 2025 17:54
@s0up4200 s0up4200 marked this pull request as ready for review July 22, 2025 19:37
@s0up4200 s0up4200 moved this to In review in TQM development Jul 22, 2025
@s0up4200 s0up4200 requested a review from nuxencs July 25, 2025 15:27
Copy link
Collaborator

@nuxencs nuxencs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't we use goreleaser-pro here or is it only enabled in autobrr/autobrr? 🤔
we should probably also use --snapshot for Run GoReleaser build and --parallelism 5 for Run GoReleaser build and publish tags.

- name: Run GoReleaser build
if: github.event_name == 'pull_request'
uses: goreleaser/goreleaser-action@v6
with:
distribution: goreleaser
version: "~> v2"
args: release --clean --skip=validate,publish --parallelism 5
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Run GoReleaser build and publish tags
if: startsWith(github.ref, 'refs/tags/')
uses: goreleaser/goreleaser-action@v6
with:
distribution: goreleaser
version: "~> v2"
args: release --clean
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

last thing: it would be nice to have it actually return a version other than main in the built image, example here from my seasonpackarr 😅
that would result in 1.15.0-dev8 for example
https://github.com/nuxencs/seasonpackarr/blob/16291f2b3ad4f88e05535acdf11465d8141390ef/.github/workflows/release.yml#L140-L178

- Add --snapshot flag to PR builds for proper snapshot releases
- Add --parallelism 5 to tag releases for faster builds
- Implement dynamic version generation for main branch builds (e.g., v1.15.0-dev8)
- Update Docker metadata to use generated versions for development builds
@s0up4200
Copy link
Contributor Author

Talked to Nuxen on Discord, re goreleaser-pro. Its available org wide, but no benefit from using as long as we dont use the pro features.

@s0up4200
Copy link
Contributor Author

This does not run in its current state, and needs more work. Will continue on it in the coming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build enhancement New feature or request
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

Build and publish Docker image to GHCR
3 participants