[Manage Submissions] Score popup modal styling + fixes #1952
Conversation
| ${problem.name} | ||
| <br> | ||
| <i> ${max_score} ${autograded} </i> | ||
| const autograded = data.autograded ? " (Autograded)" : ""; |
There was a problem hiding this comment.
Seems to erroneously mark non-autograded problems as autograded
There was a problem hiding this comment.
Note that autograded is set via autograded = @assessment.has_autograder?, so it's not a good way to check if a problem is autograded
There was a problem hiding this comment.
Don't think it makes sense for it to be a column variable and am not sure about the usefulness of (Autograded). Will remove
|
Unrelated to this PR, but the wrong tags were being used here in |
| @@ -44,14 +44,20 @@ $(document).ready(function () { | |||
|
|
|||
| // Fetch data and render it in the modal | |||
| get_score_details(course_user_datum_id).then((data) => { | |||
| const sorting_icons = | |||
There was a problem hiding this comment.
Note that once datatables-rows is correctly included, there are existing sorting icons, so there is actually no need to implement your own
There was a problem hiding this comment.
True, but I personally think we should remove the link to Datatables stylesheet and use the styling/logic Lynn implemented because:
- The default Datatables styling results in the icon appearing on all columns and sorting a column like "Actions" is weird. Disabling the icons is not straightforward: https://datatables.net/forums/discussion/41214/how-to-leave-column-sorting-enabled-but-remove-the-sorting-icons
- The icons that Lynn added looks better IMO and changing the original icons to use the materialize icons would require the same amount of code.
|
Also edited the margins so that the icons are centered
|
Summary
Summary generated by Reviewpad on 20 Sep 23 17:22 UTC
This pull request includes three patches:
Description
Adds further styling and bug fixes to the score popup modal, mainly those noted from this comment.
Motivation and Context
Part of the Manage Submissions UI overhaul.
How Has This Been Tested?
Style-related issues
Old:
New:
The score under each problem has been fixed (no longer bold, still italicized) to follow the Figma prototype
Disabled the table rows changing color (to blue) on mouseover, for both the manage submissions main table and the table in the score popup
Changed the background color for problem columns to follow the Figma prototype
Old:
New:
Old:
New:
Bug Fixes
Old:
(for incorrect file upload)
(for excused students)
New:
grader_idper problem, butgrader_idis indata.scoreswhile problems + scores came fromdata.submissions, so I useddata.autogradedto keep it simple...Old:
New:
Types of changes
Checklist:
overcommit --install && overcommit --signto use pre-commit hook for linting