feat(auto-utils): add consensus and domain existential deposit validation functions #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jfrank-summit
left a comment
jfrank-summit
left a comment
There was a problem hiding this comment.
Are you sure this is needed?
teor2345
reviewed
Sep 29, 2025
jim-counter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit existential deposit validation functions for consensus and domain chains, replacing generic functions with chain-specific variants.
New Functions
meetsConsensusExistentialDepositAi3(amount: string): boolean- Validates AI3 amounts against consensus chain ED (0.00001 AI3)meetsConsensusExistentialDepositShannons(amount: bigint): boolean- Validates Shannon amounts against consensus chain EDmeetsDomainExistentialDepositAi3(amount: string): boolean- Validates AI3 amounts against domain/EVM ED (0.000001 AI3)meetsDomainExistentialDepositShannons(amount: bigint): boolean- Validates Shannon amounts against domain/EVM EDNew Constants
DEFAULT_CONSENSUS_EXISTENTIAL_DEPOSIT_SHANNONS- 10 trillion ShannonsDEFAULT_DOMAIN_EXISTENTIAL_DEPOSIT_SHANNONS- 1 trillion ShannonsBreaking Changes
Removed deprecated generic functions:
meetsExistentialDepositAi3→ usemeetsConsensusExistentialDepositAi3meetsExistentialDepositShannons→ usemeetsConsensusExistentialDepositShannonsDEFAULT_EXISTENTIAL_DEPOSIT_SHANNONS→ use chain-specific constantsTesting
Added comprehensive test coverage (52 tests) with identical validation for both consensus and domain functions.
Addresses reviewer feedback requesting explicit chain-type functions for consensus and domain amount validation.