Skip to content

Conversation

@jfrank-summit
Copy link
Member

@jfrank-summit jfrank-summit commented Oct 16, 2025

Summary

  • Introduces an optional derivationPath parameter to wallet setup/activation for intuitive Ethereum HD derivation without changing defaults.
  • Updates example with a runnable demo and ethers parity checks.
  • Adds tests that lock in the expected Ethereum BIP44 address for a known mnemonic.

Motivation and context

Close #482

@jfrank-summit
Copy link
Member Author

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


Comment @cursor review or bugbot run to trigger another review on this PR

Copy link
Member

@jim-counter jim-counter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfrank-summit jfrank-summit merged commit 5d6c939 into main Oct 17, 2025
3 checks passed
@jfrank-summit jfrank-summit deleted the eth-key-derivation branch October 17, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ethereum Wallet Derivation Path Does Not Follow BIP44 Standard

4 participants