feat: add new wrapper method for upload file as Buffer
#488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sistency in examples
clostao
changed the title
BufferBuffer
Member
jfrank-summit
left a comment
jfrank-summit
left a comment
There was a problem hiding this comment.
The description and the diff don't match
Contributor
Author
|
Forgot to push the actual changes 😓 |
Member
jfrank-summit
left a comment
jfrank-summit
left a comment
There was a problem hiding this comment.
Looks good, just one comment.
Co-authored-by: Jeremy Frank <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a simple method for uploading a file as
BufferImpact
Other: