fix(rpc): expose onEveryOpen in RPC Client Callbacks
#496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the RPC client callback definitions to use a shared
RpcClientCallbackstype and explicitly exposes theonEveryOpencallback which was previously missing from the TypeScript definition.Motivation and Context
Fixes #495.
The
createRpcClientfunction supports anonEveryOpencallback at runtime, but the TypeScript definition for thecallbacksparameter was missing this property. This forced consumers to cast their callback objects toanyor ignore type errors when trying to use this hook (e.g., for reconnection logic).Implementation Details
packages/utility/rpc/src/rpc/types.ts:RpcClientCallbacks.onEveryOpento the interface.packages/utility/rpc/src/rpc/client.ts:createRpcClientto useRpcClientCallbacksinstead of an inline type.packages/utility/rpc/src/rpc/api/definition.ts:createApiDefinitionand its generated client to useRpcClientCallbacks.Breaking Changes
None. This is a non-breaking type definition update. The runtime behavior remains the same, but the TypeScript types are now more accurate.
Testing
onEveryOpenin a TypeScript project with this change should no longer trigger a type error.