Skip to content

Conversation

@DaMandal0rian
Copy link
Contributor

@DaMandal0rian DaMandal0rian commented Oct 17, 2024

PR Type

enhancement


Description

  • Removed all UDP port mappings and configurations across various scripts and configuration files.
  • Updated network configurations to use TCP only for all communications.
  • This change affects multiple components including bootstrap nodes, domain nodes, farmer nodes, and RPC nodes.

Changes walkthrough 📝

Relevant files
Enhancement
15 files
create_bootstrap_node_compose_file.sh
Remove UDP configurations and use TCP only                             

templates/scripts/create_bootstrap_node_compose_file.sh

  • Removed UDP port mappings and configurations.
  • Updated to use TCP only for network communications.
  • +1/-17   
    create_bootstrap_node_domain_compose_file.sh
    Remove UDP configurations and use TCP only                             

    templates/scripts/create_bootstrap_node_domain_compose_file.sh

  • Removed UDP port mappings and configurations.
  • Updated to use TCP only for network communications.
  • +2/-18   
    create_domain_node_compose_file.sh
    Remove UDP configurations and use TCP only                             

    templates/scripts/create_domain_node_compose_file.sh

  • Removed UDP port mappings and configurations.
  • Updated to use TCP only for network communications.
  • +2/-4     
    create_farmer_node_compose_file.sh
    Remove UDP configurations and use TCP only                             

    templates/scripts/create_farmer_node_compose_file.sh

  • Removed UDP port mappings and configurations.
  • Updated to use TCP only for network communications.
  • +3/-10   
    create_rpc_node_compose_file.sh
    Remove UDP configurations and use TCP only                             

    templates/scripts/create_rpc_node_compose_file.sh

  • Removed UDP port mappings and configurations.
  • Updated to use TCP only for network communications.
  • +0/-2     
    create_autoid_node_compose_file.sh
    Remove UDP configurations and use TCP only                             

    testing-framework/ec2/base/scripts/create_autoid_node_compose_file.sh

  • Removed UDP port mappings and configurations.
  • Updated to use TCP only for network communications.
  • +2/-4     
    create_bootstrap_node_autoid_compose_file.sh
    Remove UDP configurations and use TCP only                             

    testing-framework/ec2/base/scripts/create_bootstrap_node_autoid_compose_file.sh

  • Removed UDP port mappings and configurations.
  • Updated to use TCP only for network communications.
  • +2/-18   
    create_bootstrap_node_compose_file.sh
    Remove UDP configurations and use TCP only                             

    testing-framework/ec2/base/scripts/create_bootstrap_node_compose_file.sh

  • Removed UDP port mappings and configurations.
  • Updated to use TCP only for network communications.
  • +1/-17   
    create_bootstrap_node_evm_compose_file.sh
    Remove UDP configurations and use TCP only                             

    testing-framework/ec2/base/scripts/create_bootstrap_node_evm_compose_file.sh

  • Removed UDP port mappings and configurations.
  • Updated to use TCP only for network communications.
  • +2/-30   
    create_domain_node_compose_file.sh
    Remove UDP configurations and use TCP only                             

    testing-framework/ec2/base/scripts/create_domain_node_compose_file.sh

  • Removed UDP port mappings and configurations.
  • Updated to use TCP only for network communications.
  • +2/-4     
    create_farmer_node_compose_file.sh
    Remove UDP configurations and use TCP only                             

    testing-framework/ec2/base/scripts/create_farmer_node_compose_file.sh

  • Removed UDP port mappings and configurations.
  • Updated to use TCP only for network communications.
  • +3/-10   
    create_node_compose_file.sh
    Remove UDP configurations and use TCP only                             

    testing-framework/ec2/base/scripts/create_node_compose_file.sh

  • Removed UDP port mappings and configurations.
  • Updated to use TCP only for network communications.
  • +0/-2     
    docker-compose-autoid.yml
    Remove UDP configurations and use TCP only                             

    ansible/network/files/docker-compose-autoid.yml

  • Removed UDP port mappings and configurations.
  • Updated to use TCP only for network communications.
  • +4/-7     
    docker-compose-bootstrap-autoid.yml
    Remove UDP configurations and use TCP only                             

    ansible/network/files/docker-compose-bootstrap-autoid.yml

  • Removed UDP port mappings and configurations.
  • Updated to use TCP only for network communications.
  • +10/-23 
    docker-compose-bootstrap-domain.yml
    Remove UDP configurations and use TCP only                             

    ansible/network/files/docker-compose-bootstrap-domain.yml

  • Removed UDP port mappings and configurations.
  • Updated to use TCP only for network communications.
  • +10/-23 

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @github-actions github-actions bot added the enhancement New feature or request label Oct 17, 2024
    @github-actions
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Update
    Ensure that the removal of UDP and QUIC configurations and the exclusive use of TCP does not impact the expected functionality or performance of the system.

    External Address Update
    Verify that the changes to external address configurations align with network security and connectivity requirements.

    Port Configuration
    Review the changes in port configurations to ensure they meet the new network protocol requirements without unintended side effects.

    @DaMandal0rian DaMandal0rian merged commit b3fcc09 into main Oct 17, 2024
    1 check passed
    @DaMandal0rian DaMandal0rian deleted the feat/remove-udp-quic branch October 17, 2024 11:49
    @github-actions
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Maintainability
    Remove duplicate configuration entries to streamline network setup and avoid conflicts

    Check for duplicate entries in the configuration to prevent redundancy and potential
    conflicts in the network setup.

    ansible/network/files/docker-compose-bootstrap.yml [81]

    +- "/dns/bootstrap-${NODE_ID}.${NETWORK_NAME}.subspace.network/tcp/30533/p2p/${BOOTSTRAP_0_SUBSPACE_PEER_ID}"
     
    -
    Suggestion importance[1-10]: 8

    Why: The suggestion addresses a potential issue of duplicate configuration entries, which can lead to redundancy and conflicts in network setup. Removing duplicates enhances maintainability and ensures a cleaner configuration.

    8
    Possible issue
    Confirm the intentional removal of UDP and QUIC protocols to prevent unintended service disruptions

    Verify that the removal of UDP and QUIC protocol support is intentional and does not
    affect dependent services or network performance.

    ansible/network/files/docker-compose-bootstrap.yml [52]

    +- "30533:30533/tcp"
     
    -
    Suggestion importance[1-10]: 7

    Why: The suggestion is valid as it prompts verification of the removal of UDP and QUIC protocols, which could potentially impact network performance or dependent services. This is an important check to ensure no unintended disruptions occur.

    7

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants