Fix cleanup, and restart logic + fix retry logic bug

[DaMandal0rian]

PR Type

Bug fix, Enhancement

---

Description

• Removed retry logic from the run_command function, simplifying command execution over SSH.
• Enhanced Docker cleanup logic to check for running containers before attempting to stop them, preventing unnecessary errors.
• Improved the handle_node function to conditionally update the .env file with the genesis hash, enhancing flexibility.
• Added logic to handle the protocol version hash for the bootstrap node, ensuring proper node updates even if the hash is unavailable.

---

Changes walkthrough 📝

	Relevant files
Enhancement	manage_subspace.py Improve command execution and node handling logic                scripts/launch-nodes/manage_subspace.py Removed retry logic from run_command function. Improved Docker cleanup logic to check for running containers before stopping. Enhanced handle_node function to update .env file conditionally. Added logic to handle protocol version hash for bootstrap node. +84/-42

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Error Handling The new implementation of run_command does not handle retries which might be necessary for unstable network conditions. Consider reintroducing retry logic or ensuring that the calling functions manage retries appropriately. Logging Consistency The logging for Docker status updates has been changed to treat all messages as INFO unless they match specific keywords. This might suppress important error messages that do not contain these keywords. Review if this change aligns with the desired error handling and logging strategy.

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible bug	Ensure command execution is successful before processing its output Consider checking the exit status of the command execution to ensure it completed successfully before processing the output. scripts/launch-nodes/manage_subspace.py [41-43] stdin, stdout, stderr = client.exec_command(command) -output = stdout.read().decode('utf-8') -error = stderr.read().decode('utf-8') +exit_status = stdout.channel.recv_exit_status() +if exit_status == 0: + output = stdout.read().decode('utf-8') + error = stderr.read().decode('utf-8') +else: + raise Exception("Command execution failed") Suggestion importance[1-10]: 8 Why: This suggestion adds a check for the command execution's exit status, which is crucial for ensuring that the command completed successfully before processing its output. This can prevent potential errors and improve the robustness of the code.	8
	Handle errors when stopping containers to ensure cleanup process integrity Add error handling for the case where the command to stop containers fails, to prevent proceeding with pruning if stopping was unsuccessful. scripts/launch-nodes/manage_subspace.py [110-112] stop_containers_cmd = f'cd {subspace_dir} && sudo docker stop $(sudo docker ps -q)' logger.info(f"Stopping running containers in {subspace_dir}") -run_command(client, stop_containers_cmd) +output, error = run_command(client, stop_containers_cmd) +if error: + raise Exception("Failed to stop containers") Suggestion importance[1-10]: 7 Why: The suggestion introduces error handling for the container stopping command, which is important for maintaining the integrity of the cleanup process. It ensures that the pruning step is not executed if stopping containers fails, preventing potential issues.	7
	Prevent potential errors by ensuring the SSH client is initialized before use Implement a check to ensure that the client object is not None before attempting to use it in the run_command function to avoid potential NoneType errors. scripts/launch-nodes/manage_subspace.py [41-43] +if client is None: + raise ValueError("SSH client is not initialized") stdin, stdout, stderr = client.exec_command(command) output = stdout.read().decode('utf-8') error = stderr.read().decode('utf-8') Suggestion importance[1-10]: 6 Why: This suggestion adds a check to ensure the SSH client is initialized before use, which can prevent NoneType errors. While the client should typically be initialized, this check adds an extra layer of safety.	6
Maintainability	Improve code modularity and maintainability by refactoring node handling operations Refactor the logic to handle node operations in a more modular way, separating concerns and making the code easier to maintain and extend. scripts/launch-nodes/manage_subspace.py [163-178] -if prune: +def handle_prune(): docker_cleanup(client, subspace_dir) -elif restart: + +def handle_restart(): docker_compose_restart(client, subspace_dir) -else: + +def handle_update(): docker_compose_down(client, subspace_dir) modify_env_file(client, subspace_dir, release_version, ...) docker_compose_up(client, subspace_dir) +operations = { + 'prune': handle_prune, + 'restart': handle_restart, + 'update': handle_update +} +operations.get(action)() + Suggestion importance[1-10]: 5 Why: The suggestion proposes refactoring the node handling logic into separate functions, which can improve code modularity and maintainability. However, the current implementation is already clear, and the benefit of this change is moderate.	5