Skip to content

Conversation

@DaMandal0rian
Copy link
Contributor

@DaMandal0rian DaMandal0rian commented Oct 30, 2024

PR Type

enhancement


Description

  • Removed --sync full option from various node scripts and compose files to use dsn sync instead of substrate sync.
  • Uncommented --pot-external-entropy option in multiple scripts and compose files to enable external entropy usage.

Changes walkthrough 📝

Relevant files
Enhancement
24 files
create_bootstrap_node_compose_file.sh
Remove full sync option from bootstrap node script             

templates/scripts/create_bootstrap_node_compose_file.sh

  • Removed --sync full option from the command.
+0/-1     
create_bootstrap_node_domain_compose_file.sh
Remove full sync option from bootstrap domain node script

templates/scripts/create_bootstrap_node_domain_compose_file.sh

  • Removed --sync full option from the command.
+0/-1     
create_domain_node_compose_file.sh
Remove full sync option from domain node script                   

templates/scripts/create_domain_node_compose_file.sh

  • Removed --sync full option from the command.
+0/-1     
create_farmer_node_compose_file.sh
Remove full sync option from farmer node script                   

templates/scripts/create_farmer_node_compose_file.sh

  • Removed --sync full option from the command.
+0/-1     
create_rpc_node_compose_file.sh
Remove full sync option from RPC node script                         

templates/scripts/create_rpc_node_compose_file.sh

  • Removed --sync full option from the command.
+0/-1     
create_bootstrap_node_compose_file.sh
Remove full sync option from Gemini 3h bootstrap node script

templates/terraform/network-primitives-archive/gemini-3h/scripts/create_bootstrap_node_compose_file.sh

  • Removed --sync full option from the command.
+0/-1     
create_bootstrap_node_domain_compose_file.sh
Remove full sync option from Gemini 3h bootstrap domain node script

templates/terraform/network-primitives-archive/gemini-3h/scripts/create_bootstrap_node_domain_compose_file.sh

  • Removed --sync full option from the command.
+0/-1     
create_domain_node_compose_file.sh
Remove full sync option from Gemini 3h domain node script

templates/terraform/network-primitives-archive/gemini-3h/scripts/create_domain_node_compose_file.sh

  • Removed --sync full option from the command.
+0/-1     
create_farmer_node_compose_file.sh
Remove full sync option from Gemini 3h farmer node script

templates/terraform/network-primitives-archive/gemini-3h/scripts/create_farmer_node_compose_file.sh

  • Removed --sync full option from the command.
+0/-1     
create_rpc_node_compose_file.sh
Remove full sync option from Gemini 3h RPC node script     

templates/terraform/network-primitives-archive/gemini-3h/scripts/create_rpc_node_compose_file.sh

  • Removed --sync full option from the command.
+0/-1     
create_autoid_node_compose_file.sh
Enable external entropy option in autoid node script         

testing-framework/ec2/base/scripts/create_autoid_node_compose_file.sh

  • Uncommented --pot-external-entropy option in the command.
+1/-1     
create_bootstrap_node_autoid_compose_file.sh
Enable external entropy option in bootstrap autoid node script

testing-framework/ec2/base/scripts/create_bootstrap_node_autoid_compose_file.sh

  • Uncommented --pot-external-entropy option in the command.
+1/-1     
create_bootstrap_node_compose_file.sh
Enable external entropy option in bootstrap node script   

testing-framework/ec2/base/scripts/create_bootstrap_node_compose_file.sh

  • Uncommented --pot-external-entropy option in the command.
+1/-1     
create_bootstrap_node_evm_compose_file.sh
Enable external entropy option in bootstrap EVM node script

testing-framework/ec2/base/scripts/create_bootstrap_node_evm_compose_file.sh

  • Uncommented --pot-external-entropy option in the command.
+1/-1     
create_domain_node_compose_file.sh
Enable external entropy option in domain node script         

testing-framework/ec2/base/scripts/create_domain_node_compose_file.sh

  • Uncommented --pot-external-entropy option in the command.
+1/-1     
create_farmer_node_compose_file.sh
Enable external entropy option in farmer node script         

testing-framework/ec2/base/scripts/create_farmer_node_compose_file.sh

  • Uncommented --pot-external-entropy option in the command.
+1/-1     
create_node_compose_file.sh
Enable external entropy option in node script                       

testing-framework/ec2/base/scripts/create_node_compose_file.sh

  • Uncommented --pot-external-entropy option in the command.
+1/-1     
docker-compose-autoid.yml
Enable external entropy option in autoid compose file       

ansible/network/files/docker-compose-autoid.yml

  • Uncommented --pot-external-entropy option in the command.
+1/-1     
docker-compose-bootstrap-autoid.yml
Enable external entropy option in bootstrap autoid compose file

ansible/network/files/docker-compose-bootstrap-autoid.yml

  • Uncommented --pot-external-entropy option in the command.
+1/-1     
docker-compose-bootstrap-domain.yml
Update bootstrap domain compose file options                         

ansible/network/files/docker-compose-bootstrap-domain.yml

  • Removed --sync full option from the command.
  • Uncommented --pot-external-entropy option in the command.
  • +1/-2     
    docker-compose-bootstrap.yml
    Update bootstrap compose file options                                       

    ansible/network/files/docker-compose-bootstrap.yml

  • Removed --sync full option from the command.
  • Uncommented --pot-external-entropy option in the command.
  • +1/-2     
    docker-compose-domain.yml
    Update domain compose file options                                             

    ansible/network/files/docker-compose-domain.yml

  • Removed --sync full option from the command.
  • Uncommented --pot-external-entropy option in the command.
  • +1/-2     
    docker-compose-farmer.yml
    Update farmer compose file options                                             

    ansible/network/files/docker-compose-farmer.yml

  • Removed --sync full option from the command.
  • Uncommented --pot-external-entropy option in the command.
  • +1/-2     
    docker-compose-rpc.yml
    Update RPC compose file options                                                   

    ansible/network/files/docker-compose-rpc.yml

  • Removed --sync full option from the command.
  • Uncommented --pot-external-entropy option in the command.
  • +1/-2     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @github-actions
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Change
    The removal of --sync full and addition of --pot-external-entropy could affect node synchronization behavior and entropy usage. Ensure these changes align with system requirements and security standards.

    @github-actions
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Contributor

    @teor2345 teor2345 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This looks good to me, I just want to check with @shamil-gadelshin or @nazar-pc to make sure we’re ready to move to snap sync.

    @DaMandal0rian DaMandal0rian merged commit 1fdf217 into main Oct 31, 2024
    1 check passed
    @DaMandal0rian DaMandal0rian deleted the feat/snap-sync branch October 31, 2024 14:06
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants