add feature to wipe mounted farmer directory

[DaMandal0rian]

PR Type

enhancement, documentation

---

Description

• Introduced a new feature to wipe farmer data while preserving the identity.bin file in the manage_subspace.py script.
• Added a --wipe command-line argument to allow users to trigger the data wipe functionality.
• Updated the README.md to document the new --wipe option and its usage.

---

Changes walkthrough 📝

	Relevant files
Enhancement	manage_subspace.py Add functionality to wipe farmer data with preservation    scripts/launch-nodes/manage_subspace.py Added wipe_farmer_data function to wipe farmer data while preserving identity.bin. Integrated wipe option into handle_node function to conditionally wipe farmer data. Added --wipe argument to the command-line interface. +45/-2
Documentation	README.md Update documentation for wipe feature                                        scripts/launch-nodes/README.md Documented the new --wipe command-line argument. Updated usage instructions to include the --wipe option. +2/-0

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 Security concerns Command Injection: The implementation of the wipe_farmer_data function involves constructing shell commands with directory paths that could potentially be manipulated if external inputs are not properly sanitized or validated.

⚡ Recommended focus areas for review Command Injection The use of shell commands constructed with user input without proper sanitization may lead to command injection vulnerabilities. Error Handling The error handling in the wipe_farmer_data function may not catch all specific errors related to file and directory operations effectively.

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible bug	Improve reliability by adding error checks after each command execution in the data wipe process Add error handling for each command execution within the wipe_farmer_data function to ensure each step completes successfully before proceeding. scripts/launch-nodes/manage_subspace.py [84-86] stdout, stderr = run_command(client, command) if stderr and not any(keyword in stderr for keyword in ["No such file", "not found"]): logger.error(f"Error during farmer data wipe: {stderr}") + raise Exception("Command execution failed") Suggestion importance[1-10]: 8 Why: Adding error handling to raise exceptions when command execution fails enhances the robustness of the function, ensuring that errors are caught and handled appropriately, which is crucial for maintaining data integrity.	8
Performance	Optimize the script by reducing redundant directory change commands Replace the sequence of cd commands with a single cd at the beginning of the script to enhance efficiency and reduce redundancy. scripts/launch-nodes/manage_subspace.py [61-79] -f"cd {subspace_dir} && sudo mkdir -p backup", -f"cd {subspace_dir} && if [ -f farmer_data/identity.bin ]; then sudo mv farmer_data/identity.bin backup/; fi", -f"cd {subspace_dir} && sudo rm -rf farmer_data", -f"cd {subspace_dir} && sudo mkdir -p farmer_data", -f"cd {subspace_dir} && if [ -f backup/identity.bin ]; then sudo mv backup/identity.bin farmer_data/; fi", -f"cd {subspace_dir} && sudo chown -R nobody:nogroup farmer_data/", -f"cd {subspace_dir} && sudo rm -rf backup" +f"cd {subspace_dir}", +f"sudo mkdir -p backup", +f"if [ -f farmer_data/identity.bin ]; then sudo mv farmer_data/identity.bin backup/; fi", +f"sudo rm -rf farmer_data", +f"sudo mkdir -p farmer_data", +f"if [ -f backup/identity.bin ]; then sudo mv backup/identity.bin farmer_data/; fi", +f"sudo chown -R nobody:nogroup farmer_data/", +f"sudo rm -rf backup" Suggestion importance[1-10]: 7 Why: The suggestion effectively reduces redundancy by consolidating multiple cd commands into a single one, improving script efficiency and readability without altering functionality.	7
Best practice	Improve script robustness by using absolute paths for file operations Use absolute paths for file operations instead of changing directories, to avoid potential issues with relative paths. scripts/launch-nodes/manage_subspace.py [61-79] -f"cd {subspace_dir} && sudo mkdir -p backup", -f"cd {subspace_dir} && if [ -f farmer_data/identity.bin ]; then sudo mv farmer_data/identity.bin backup/; fi", -f"cd {subspace_dir} && sudo rm -rf farmer_data", -f"cd {subspace_dir} && sudo mkdir -p farmer_data", -f"cd {subspace_dir} && if [ -f backup/identity.bin ]; then sudo mv backup/identity.bin farmer_data/; fi", -f"cd {subspace_dir} && sudo chown -R nobody:nogroup farmer_data/", -f"cd {subspace_dir} && sudo rm -rf backup" +f"sudo mkdir -p {subspace_dir}/backup", +f"if [ -f {subspace_dir}/farmer_data/identity.bin ]; then sudo mv {subspace_dir}/farmer_data/identity.bin {subspace_dir}/backup/; fi", +f"sudo rm -rf {subspace_dir}/farmer_data", +f"sudo mkdir -p {subspace_dir}/farmer_data", +f"if [ -f {subspace_dir}/backup/identity.bin ]; then sudo mv {subspace_dir}/backup/identity.bin {subspace_dir}/farmer_data/; fi", +f"sudo chown -R nobody:nogroup {subspace_dir}/farmer_data", +f"sudo rm -rf {subspace_dir}/backup" Suggestion importance[1-10]: 7 Why: Using absolute paths enhances the script's robustness by reducing potential issues with relative paths, especially in complex environments, thereby improving reliability and maintainability.	7
Security	Enhance security by securely deleting the backup directory to prevent potential data recovery Ensure that the backup directory is securely deleted by overwriting it before removal to prevent data recovery. scripts/launch-nodes/manage_subspace.py [79] -f"cd {subspace_dir} && sudo rm -rf backup" +f"cd {subspace_dir} && sudo shred -u backup/* && sudo rm -rf backup" Suggestion importance[1-10]: 6 Why: The suggestion to use shred for secure deletion adds a layer of security by preventing data recovery, which is beneficial in scenarios where sensitive data might be involved, though it may not be necessary for all use cases.	6