Skip to content

Conversation

@DaMandal0rian
Copy link
Contributor

@DaMandal0rian DaMandal0rian commented Nov 14, 2024

PR Type

enhancement


Description

  • Updated the metrics flag across multiple scripts and configuration files from --metrics-endpoints or --metrics-endpoint to --prometheus-listen-on.
  • Changes affect shell scripts, YAML configuration files for Docker Compose, and Kubernetes configurations.
  • This change standardizes the metrics flag usage across different environments and setups.

Changes walkthrough 📝

Relevant files
Enhancement
17 files
create_bootstrap_node_compose_file.sh
Update metrics flag in bootstrap node compose script         

templates/scripts/create_bootstrap_node_compose_file.sh

  • Changed metrics flag from --metrics-endpoints to
    --prometheus-listen-ons.
  • +1/-1     
    create_bootstrap_node_domain_compose_file.sh
    Update metrics flag in bootstrap node domain compose script

    templates/scripts/create_bootstrap_node_domain_compose_file.sh

  • Changed metrics flag from --metrics-endpoints to
    --prometheus-listen-ons.
  • +1/-1     
    create_farmer_node_compose_file.sh
    Update metrics flag in farmer node compose script               

    templates/scripts/create_farmer_node_compose_file.sh

  • Changed metrics flag from --metrics-endpoint to
    --prometheus-listen-on.
  • +1/-1     
    create_bootstrap_node_compose_file.sh
    Update metrics flag in archived bootstrap node compose script

    templates/terraform/network-primitives-archive/gemini-3h/scripts/create_bootstrap_node_compose_file.sh

  • Changed metrics flag from --metrics-endpoints to
    --prometheus-listen-ons.
  • +1/-1     
    create_bootstrap_node_domain_compose_file.sh
    Update metrics flag in archived bootstrap node domain compose script

    templates/terraform/network-primitives-archive/gemini-3h/scripts/create_bootstrap_node_domain_compose_file.sh

  • Changed metrics flag from --metrics-endpoints to
    --prometheus-listen-ons.
  • +1/-1     
    create_farmer_node_compose_file.sh
    Update metrics flag in archived farmer node compose script

    templates/terraform/network-primitives-archive/gemini-3h/scripts/create_farmer_node_compose_file.sh

  • Changed metrics flag from --metrics-endpoint to
    --prometheus-listen-on.
  • +1/-1     
    create_bootstrap_node_autoid_compose_file.sh
    Update metrics flag in EC2 autoid bootstrap node compose script

    testing-framework/ec2/base/scripts/create_bootstrap_node_autoid_compose_file.sh

  • Changed metrics flag from --metrics-endpoints to
    --prometheus-listen-ons.
  • +1/-1     
    create_bootstrap_node_compose_file.sh
    Update metrics flag in EC2 bootstrap node compose script 

    testing-framework/ec2/base/scripts/create_bootstrap_node_compose_file.sh

  • Changed metrics flag from --metrics-endpoints to
    --prometheus-listen-ons.
  • +1/-1     
    create_bootstrap_node_evm_compose_file.sh
    Update metrics flag in EC2 EVM bootstrap node compose script

    testing-framework/ec2/base/scripts/create_bootstrap_node_evm_compose_file.sh

  • Changed metrics flag from --metrics-endpoints to
    --prometheus-listen-ons.
  • +1/-1     
    create_farmer_node_compose_file.sh
    Update metrics flag in EC2 farmer node compose script       

    testing-framework/ec2/base/scripts/create_farmer_node_compose_file.sh

  • Changed metrics flag from --metrics-endpoint to
    --prometheus-listen-on.
  • +1/-1     
    docker-compose-bootstrap-autoid.yml
    Update metrics flag in Ansible autoid bootstrap compose file

    ansible/network/files/docker-compose-bootstrap-autoid.yml

  • Changed metrics flag from --metrics-endpoints to
    --prometheus-listen-ons.
  • +1/-1     
    docker-compose-bootstrap-domain.yml
    Update metrics flag in Ansible domain bootstrap compose file

    ansible/network/files/docker-compose-bootstrap-domain.yml

  • Changed metrics flag from --metrics-endpoints to
    --prometheus-listen-ons.
  • +1/-1     
    docker-compose-bootstrap.yml
    Update metrics flag in Ansible bootstrap compose file       

    ansible/network/files/docker-compose-bootstrap.yml

  • Changed metrics flag from --metrics-endpoints to
    --prometheus-listen-ons.
  • +1/-1     
    docker-compose-farmer.yml
    Update metrics flag in Ansible farmer compose file             

    ansible/network/files/docker-compose-farmer.yml

  • Changed metrics flag from --metrics-endpoint to
    --prometheus-listen-on.
  • +1/-1     
    archival-node.yaml
    Update metrics flag in Kubernetes domain node archival config

    kubernetes/devnet/base/bootstrap-domain-node/archival-node.yaml

  • Changed metrics flag from --metrics-endpoints to
    --prometheus-listen-ons.
  • +1/-1     
    archival-node.yaml
    Update metrics flag in Kubernetes bootstrap node archival config

    kubernetes/devnet/base/bootstrap-node/archival-node.yaml

  • Changed metrics flag from --metrics-endpoints to
    --prometheus-listen-ons.
  • +1/-1     
    archival-node.yaml
    Update metrics flag in Kubernetes farmer archival config 

    kubernetes/devnet/base/farmer/archival-node.yaml

  • Changed metrics flag from --metrics-endpoint to
    --prometheus-listen-on.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @github-actions
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Typo in Flag
    The flag --prometheus-listen-ons might be a typo. It should be consistently named across all files, possibly intended as --prometheus-listen-on.

    @github-actions
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Typo
    Correct a typo in the Prometheus flag to ensure the correct functionality

    Correct the typo in the flag name from "--prometheus-listen-ons" to
    "--prometheus-listen-on".

    templates/scripts/create_bootstrap_node_compose_file.sh [63]

    -- "--prometheus-listen-ons=0.0.0.0:9616"
    +- "--prometheus-listen-on=0.0.0.0:9616"
    Suggestion importance[1-10]: 10

    Why: The suggestion corrects a critical typo in the Prometheus configuration flag, which is essential for proper monitoring setup and functionality. This change ensures that the Prometheus listener is correctly configured.

    10

    @DaMandal0rian DaMandal0rian merged commit 3d316e5 into main Nov 14, 2024
    @DaMandal0rian DaMandal0rian deleted the hotfix/network-metrics branch November 14, 2024 21:21
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants