fixes to network primitives domains and devnet

[DaMandal0rian]

PR Type

enhancement, configuration changes

---

Description

• Updated the devnet module configurations, including paths for scripts and configs, deployment versions, and docker tags.
• Added new node configurations and modified existing ones, including RPC indexer and nova indexer nodes.
• Updated output variables to reflect new node configurations and added outputs for new node types.
• Introduced new variables for cache percentage and thread pool size, and updated default values for instance types and counts.
• Modified DNS records to use IPv4 addresses and adjusted instance indexing logic.
• Cleaned up script files by removing commented configurations and updating parameter formats.

---

Changes walkthrough 📝

	Relevant files
Configuration changes	7 files main.tf Update devnet module configurations and paths                        resources/devnet/main.tf Updated paths for scripts and configs. Changed deployment version and docker tags. Added new node configurations and modified existing ones. Updated domain and node configurations with new parameters. +45/-42  outputs.tf Modify outputs for new node configurations                              resources/devnet/outputs.tf Updated output variables for new node configurations. Added outputs for new node types and entropy. +21/-10  variables.tf Add and update variables for network configuration              resources/devnet/variables.tf Added new variables for network configuration. Updated default values for instance types and counts. Introduced new variables for cache and thread pool. +43/-16  autoid_node_provisioner.tf Update script source for autoid node provisioner                  templates/terraform/network-primitives/autoid_node_provisioner.tf Changed script source for compose file creation. +1/-1      dns.tf Update DNS records to use IPv4 addresses                                  templates/terraform/network-primitives/dns.tf Modified DNS records to use IPv4 addresses. Adjusted instance indexing logic. +3/-3      evm_node_provisioner.tf Change source file for EVM node keys                                          templates/terraform/network-primitives/evm_node_provisioner.tf Updated source file for node keys. +1/-1      create_farmer_node_compose_file.sh Update prometheus listen-on parameter format                          templates/scripts/create_farmer_node_compose_file.sh Changed format for prometheus listen-on parameter. +1/-1
Formatting	2 files create_domain_node_compose_file.sh Clean up rate limiting configuration comments                        templates/scripts/create_domain_node_compose_file.sh Removed commented rate limiting configuration. +0/-1      create_rpc_node_compose_file.sh Clean up rate limiting configuration comments                        templates/scripts/create_rpc_node_compose_file.sh Removed commented rate limiting configuration. +0/-1

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Configuration Consistency The deployment versions for all node configurations are set to 0. This might be an oversight or incorrect during a major update. It's crucial to ensure that these values are intended and consistent with the deployment strategy. Hardcoded Values The genesis hash is hardcoded across multiple node configurations. This could lead to issues if the genesis block changes and these values are not updated accordingly. Docker Tag Consistency All docker tags are updated to "mainnet-2024-nov-18". Ensure this tag is correct and reflects the appropriate environment for all instances. Default Values Several default values for instance types and counts have been changed. It's important to validate that these new defaults are suitable for the expected load and cost implications.

[github-actions]

PR Code Suggestions ✨

No code suggestions found for the PR.