Skip to content

Conversation

@DaMandal0rian
Copy link
Contributor

@DaMandal0rian DaMandal0rian commented Nov 28, 2024

PR Type

enhancement


Description

  • Updated domain prefixes from nova to auto-evm across multiple Terraform configuration files.
  • Modified default domain labels to reflect the new auto-evm naming convention.
  • Added POT_EXTERNAL_ENTROPY configuration to bootstrap node provisioners for both autoid and evm.
  • Updated DNS record names to dynamically use the new domain prefixes.

Changes walkthrough 📝

Relevant files
Enhancement
main.tf
Update domain prefixes for mainnet configuration                 

resources/mainnet/main.tf

  • Updated domain-prefix from nova-indexer to auto-evm-indexer.
  • Changed domain prefix list from ["nova", "autoid"] to ["auto-evm",
    "autoid"].
  • +2/-2     
    variables.tf
    Update default domain labels in variables                               

    resources/mainnet/variables.tf

  • Modified default domain_labels from ["nova", "autoid"] to ["auto-evm",
    "autoid"].
  • +1/-1     
    main.tf
    Update domain prefixes for taurus configuration                   

    resources/taurus/main.tf

  • Updated domain-prefix from nova-indexer to auto-evm-indexer.
  • Changed domain prefix list from ["nova", "autoid"] to ["auto-evm",
    "autoid"].
  • +2/-2     
    variables.tf
    Update default domain labels in taurus variables                 

    resources/taurus/variables.tf

  • Modified default domain_labels from ["nova", "autoid"] to ["auto-evm",
    "autoid"].
  • +1/-1     
    bootstrap_node_autoid_provisioner.tf
    Add external entropy configuration to autoid bootstrap     

    templates/terraform/network-primitives/bootstrap_node_autoid_provisioner.tf

    • Added POT_EXTERNAL_ENTROPY to environment setup.
    +1/-0     
    bootstrap_node_evm_provisioner.tf
    Add external entropy configuration to evm bootstrap           

    templates/terraform/network-primitives/bootstrap_node_evm_provisioner.tf

    • Added POT_EXTERNAL_ENTROPY to environment setup.
    +1/-0     
    dns.tf
    Use dynamic domain prefixes in DNS records                             

    templates/terraform/network-primitives/dns.tf

    • Updated DNS record names to use dynamic domain prefixes.
    +4/-4     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @github-actions
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Code Smell
    The comment '//todo change this to a map' suggests an incomplete refactor or future work that should be addressed or tracked via a formal task or issue.

    @github-actions
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @DaMandal0rian DaMandal0rian merged commit 60de85e into main Nov 28, 2024
    1 check passed
    @DaMandal0rian DaMandal0rian deleted the feat/update-evm-label branch November 28, 2024 17:10
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    Status: Done

    Development

    Successfully merging this pull request may close these issues.

    2 participants