rename module to metal

[DaMandal0rian]

User description

rename module to not be opinionated on a provider.

---

PR Type

enhancement

---

Description

• Introduced Terraform configurations for provisioning various node types.

• Added support for dynamic node configurations using variables.

• Implemented resource provisioning for bootstrap, domain, farmer, and general nodes.

• Defined outputs for node IP addresses and other configurations.

---

Changes walkthrough 📝

Relevant files

Enhancement

bootstrap_node_domain_provisioner.tf Add bootstrap domain node provisioning resources                  templates/terraform/metal/bootstrap_node_domain_provisioner.tf Added resources for setting up bootstrap domain nodes. Included provisioning steps for Docker, scripts, and configurations. Added dynamic triggers and connections for domain nodes. Implemented pruning and deployment logic for domain nodes. [link]    bootstrap_node_provisioner.tf Add bootstrap node provisioning resources                                templates/terraform/metal/bootstrap_node_provisioner.tf Added resources for setting up bootstrap nodes. Included provisioning steps for Docker, scripts, and configurations. Added dynamic triggers and connections for bootstrap nodes. Implemented pruning and deployment logic for bootstrap nodes. [link]    domain_node_provisioner.tf Add domain node provisioning resources                                      templates/terraform/metal/domain_node_provisioner.tf Added resources for setting up domain nodes. Included provisioning steps for Docker, scripts, and configurations. Added dynamic triggers and connections for domain nodes. Implemented pruning and deployment logic for domain nodes. [link]    farmer_node_provisioner.tf Add farmer node provisioning resources                                      templates/terraform/metal/farmer_node_provisioner.tf Added resources for setting up farmer nodes. Included provisioning steps for Docker, scripts, and configurations. Added dynamic triggers and connections for farmer nodes. Implemented pruning and deployment logic for farmer nodes. [link]    node_provisioner.tf Add general node provisioning resources                                    templates/terraform/metal/node_provisioner.tf Added resources for setting up general nodes. Included provisioning steps for Docker, scripts, and configurations. Added dynamic triggers and connections for nodes. Implemented pruning and deployment logic for nodes. [link]    outputs.tf Define outputs for node IP addresses                                          templates/terraform/metal/outputs.tf Added outputs for various node IP addresses. Defined descriptions for each output variable. [link]    variables.tf Add variables for dynamic node configurations                        templates/terraform/metal/variables.tf Defined variables for dynamic node configurations. Included configurations for bootstrap, domain, farmer, and general nodes. Added sensitive and descriptive variables for Terraform provisioning. [link]

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 5 🔵🔵🔵🔵🔵

🧪 No relevant tests

🔒 Security concerns Sensitive information exposure: The tf_token variable is marked as sensitive, but ensure that it is not logged or exposed in any way during execution. Additionally, verify that the private_key_path is securely managed and not accessible to unauthorized users.

⚡ Recommended focus areas for review Possible Configuration Error The local.bootstrap_nodes_domain_ip_v4 variable is being flattened and used extensively. Ensure that the input variable var.bootstrap-node-domain-config.additional-node-ips is properly validated to avoid runtime errors or unexpected behavior. locals { bootstrap_nodes_domain_ip_v4 = flatten([ [var.bootstrap-node-domain-config.additional-node-ips] ] ) } Typographical Error The output bootstrap-node-domain-ipv4-addresses references local.bootstrap_nodes-domain_ip_v4, which appears to have an incorrect hyphen in the variable name. This could lead to runtime errors. output "bootstrap-node-domain-ipv4-addresses" { value = local.bootstrap_nodes-domain_ip_v4 description = "Bootstrap node domain IPv4 Addresses" Missing Validation The variables.tf file lacks validation rules for critical variables like var.node-config, var.domain-node-config, etc. Adding validation blocks would help ensure the correctness of the input data. variable "network_name" { description = "Network name" type = string } variable "path_to_scripts" { description = "Path to the scripts" type = string } variable "node-config" { description = "Full node deployment config" type = object({ deployment-version = number instance-count = number repo-org = string docker-tag = string additional-node-ips = list(string) reserved-only = bool prune = bool node-dsn-port = number }) } variable "domain-node-config" { description = "Domain node deployment config" type = object({ deployment-version = number instance-count = number repo-org = string docker-tag = string additional-node-ips = list(string) domain-prefix = list(string) reserved-only = bool prune = bool node-dsn-port = number enable-domains = bool domain-id = list(number) domain-labels = list(string) }) } variable "bootstrap-node-config" { description = "Bootstrap node deployment config" type = object({ deployment-version = number instance-count = number repo-org = string docker-tag = string additional-node-ips = list(string) reserved-only = bool prune = bool genesis-hash = string dsn-listen-port = number node-dsn-port = number }) } variable "bootstrap-node-domain-config" { description = "Bootstrap node domain deployment config" type = object({ deployment-version = number instance-count = number repo-org = string docker-tag = string additional-node-ips = list(string) reserved-only = bool prune = bool genesis-hash = string dsn-listen-port = number node-dsn-port = number operator-port = number }) } variable "farmer-node-config" { description = "Farmer and Node configuration" type = object({ deployment-version = number instance-count = number repo-org = string docker-tag = string additional-node-ips = list(string) reserved-only = bool prune = bool plot-size = string cache-percentage = number thread_pool_size = number reward-address = string force-block-production = bool node-dsn-port = number }) } variable "ssh_user" { type = string } variable "tf_token" { type = string sensitive = true } variable "private_key_path" { type = string } variable "branch_name" { description = "name of testing branch" type = string } variable "genesis_hash" { description = "Genesis hash" type = string }

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Validate IP addresses in local variables Ensure that the local.bootstrap_nodes_domain_ip_v4 variable is properly validated to avoid runtime errors if var.bootstrap-node-domain-config.additional-node-ips is empty or contains invalid IP addresses. templates/terraform/metal/bootstrap_node_domain_provisioner.tf [1-6] locals { bootstrap_nodes_domain_ip_v4 = flatten([ - [var.bootstrap-node-domain-config.additional-node-ips] + [for ip in var.bootstrap-node-domain-config.additional-node-ips : ip if can(regex("^(?:[0-9]{1,3}\.){3}[0-9]{1,3}$", ip))] ] ) } Suggestion importance[1-10]: 8 Why: The suggestion adds validation for IP addresses in the local.bootstrap_nodes_domain_ip_v4 variable, which helps prevent runtime errors caused by invalid or empty IP addresses. This is a significant improvement in ensuring the robustness and correctness of the code.	8