Fix auto-drive networking

[DaMandal0rian]

User description

• decrease instance count to 1
• add ssh key to server on launch

---

PR Type

Enhancement

---

Description

• Reduced default instance count for auto-drive and gateway modules.

• Added SSH configuration variables for user and private key path.

• Configured SSH connection block for EC2 instances.

• Updated Terraform variables to support SSH access.

---

Changes walkthrough 📝

Relevant files

Enhancement

variables.tf Update instance count and add SSH variables                            auto-drive/variables.tf Reduced default instance count for auto-drive and gateway modules. Added new variables for SSH user and private key path. +14/-2    main.tf Add SSH connection block for EC2 instances                              templates/terraform/aws/ec2/main.tf Added SSH connection block for EC2 instances. Configured SSH user and private key for access. +9/-0      variables.tf Add SSH configuration variables for EC2                                    templates/terraform/aws/ec2/variables.tf Added variables for SSH user and private key path. Enhanced configuration for SSH access to instances. +12/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Default Instance Count Change The default instance count for auto_drive_instance_count and gateway_instance_count has been reduced to 1. Ensure this change aligns with the intended deployment requirements and does not negatively impact system functionality. default = 1 } variable "gateway_instance_count" { description = "Number of gateway instances to create." type = number default = 1 SSH Connection Configuration The SSH connection block has been added to the EC2 instance resource. Verify that the host, user, and private_key configurations are correct and secure, and ensure the timeout value is appropriate for the use case. # Setting up the ssh connection connection { type = "ssh" host = element(self.*.public_ip, count.index) user = var.ssh_user private_key = file("${var.private_key_path}") timeout = "300s"

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Validate the SSH private key file path Ensure that the private_key file path provided in the connection block is valid and accessible, as using an incorrect or inaccessible path could lead to SSH connection failures during provisioning. templates/terraform/aws/ec2/main.tf [56] -private_key = file("${var.private_key_path}") +private_key = file("${var.private_key_path}") # Ensure this path is valid and the file is accessible Suggestion importance[1-10]: 7 Why: Ensuring the private key file path is valid and accessible is crucial for successful SSH connections during provisioning. While the suggestion is actionable, it does not provide a direct implementation for validation, slightly reducing its impact.	7
	Validate the SSH connection host variable Add error handling or validation to ensure that the host variable in the connection block resolves to a valid IP address or hostname, as incorrect values could prevent SSH connections. templates/terraform/aws/ec2/main.tf [54] -host = element(self.*.public_ip, count.index) +host = element(self.*.public_ip, count.index) # Ensure this resolves to a valid IP or hostname Suggestion importance[1-10]: 7 Why: Validating the host variable to ensure it resolves to a valid IP or hostname is important for preventing SSH connection failures. However, the suggestion only advises validation without providing a specific implementation, which limits its immediate utility.	7
General	Document reduced instance count impact Consider documenting the implications of reducing the default instance count for auto_drive_instance_count and gateway_instance_count, as this change might affect system performance or availability. auto-drive/variables.tf [73-79] -default = 1 +default = 1 # Note: Lowering the instance count may impact performance or availability Suggestion importance[1-10]: 6 Why: Adding documentation about the implications of reducing the default instance count improves clarity and helps users understand potential performance or availability impacts. However, the suggestion is not critical and does not address a functional issue.	6
	Validate SSH user and key defaults Validate the default values for ssh_user and private_key_path to ensure they align with the intended environment, as incorrect defaults could cause provisioning issues. auto-drive/variables.tf [107-113] -default = "ubuntu" +default = "ubuntu" # Ensure this matches the intended environment Suggestion importance[1-10]: 6 Why: Validating the default values for ssh_user and private_key_path ensures they align with the intended environment, reducing the risk of provisioning issues. The suggestion is helpful but lacks a direct implementation, which limits its impact.	6