Skip to content

Conversation

@DaMandal0rian
Copy link
Contributor

@DaMandal0rian DaMandal0rian commented Mar 19, 2025

PR Type

  • Enhancement

Description

  • Add access log flags to traefik commands.

  • Configure Loki logging driver with loki-url option.

  • Set traefik network for RPC compose file.


Changes walkthrough 📝

Relevant files
Enhancement
create_domain_node_compose_file.sh
Domain file logging enhancements.                                               

templates/scripts/create_domain_node_compose_file.sh

  • Added --accesslog=true and --accesslog.format=common to command.
  • Configured Loki logging driver with loki-url option.
  • +6/-0     
    create_rpc_node_compose_file.sh
    RPC file logging enhancements.                                                     

    templates/scripts/create_rpc_node_compose_file.sh

  • Added --accesslog=true and --accesslog.format=common to command.
  • Introduced traefik.docker.network=traefik-proxy parameter.
  • Configured Loki logging driver with loki-url option.
  • +7/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Logging Config

    Validate that the Loki logging configuration (including the driver and URL) is correct and aligns with deployment expectations.

    logging:
      driver: loki
      options:
        loki-url: "https://logging.subspace.network/loki/api/v1/push"
    Logging Config

    Confirm that the added Loki logging block is correctly configured and consistent with the domain node configuration.

    logging:
      driver: loki
      options:
        loki-url: "https://logging.subspace.network/loki/api/v1/push"
    Network Flag

    Review the additional network flag for Traefik to ensure that it is necessary and correctly configured for the RPC setup.

    - "traefik.docker.network=traefik-proxy"

    @github-actions
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Verify network flag format

    Confirm that the traefik.docker.network=traefik-proxy flag is correctly formed and
    intended as a command parameter, ensuring consistent string quoting and behavior
    across deployments.

    templates/scripts/create_rpc_node_compose_file.sh [68]

     - --log.level=info
     - --accesslog=true
     - --accesslog.format=common
     - --entrypoints.web.address=:80
     - --entrypoints.web.http.redirections.entryPoint.to=websecure
     - --entrypoints.websecure.address=:443
     - --providers.docker=true
     - --providers.docker.exposedbydefault=false
     - [email protected]
     - --certificatesresolvers.le.acme.storage=/acme.json
     - --certificatesresolvers.le.acme.tlschallenge=true
    -- "traefik.docker.network=traefik-proxy"
    +- traefik.docker.network=traefik-proxy
    Suggestion importance[1-10]: 5

    __

    Why: The suggestion addresses a potential inconsistency in quoting for the traefik network flag by recommending its removal, which improves consistency and may prevent misinterpretation; however, it is a minor stylistic improvement rather than a major functional correction.

    Low
    Validate logging configuration

    Verify that the newly added access log flags and the appended logging section are
    supported and correctly positioned in the configuration to prevent misconfiguration.

    templates/scripts/create_domain_node_compose_file.sh [57-61]

     - --log.level=info
     - --accesslog=true
     - --accesslog.format=common
     - --entrypoints.web.address=:80
     - --entrypoints.web.http.redirections.entryPoint.to=websecure
    +...
    +logging:
    +  driver: loki
    +  options:
    +    loki-url: "https://logging.subspace.network/loki/api/v1/push"
    Suggestion importance[1-10]: 3

    __

    Why: The suggestion is a verification check to ensure the newly added access log flags and logging section are valid, which is useful though not a critical change; it is mostly a prompt for review rather than an actionable modification.

    Low

    Copy link

    @marc-aurele-besner marc-aurele-besner left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @DaMandal0rian DaMandal0rian merged commit 4a417ec into main Mar 19, 2025
    1 check passed
    @DaMandal0rian DaMandal0rian deleted the chore/taurus-tf branch March 19, 2025 19:56
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants