Skip to content

Conversation

@DaMandal0rian
Copy link
Contributor

@DaMandal0rian DaMandal0rian commented May 27, 2025

PR Type

Enhancement


Description

  • Bump docker-tag to taurus-2025-may-27

  • Apply version update to all node modules


Changes walkthrough 📝

Relevant files
Configuration changes
main.tf
Update docker-tag across node configurations                         

resources/terraform/taurus/main.tf

  • Replaced docker-tag from taurus-2025-apr-07
  • Updated to taurus-2025-may-27 in eight configs
  • +8/-8     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Hardcoded Version Duplication

    The docker-tag value is repeated across multiple node configurations, making future upgrades error-prone. Consider centralizing this version into a variable or local to avoid manual repetition in each block.

      docker-tag         = "taurus-2025-may-27"
      reserved-only      = false
      prune              = false
      genesis-hash       = "295aeafca762a304d92ee1505548695091f6082d3f0aa4d092ac3cd6397a6c5e"
      dsn-listen-port    = 30533
      node-dsn-port      = 30433
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    bootstrap-node-evm-config = {
      instance-type      = var.instance_type["evm_bootstrap"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["evm_bootstrap"]
      docker-org         = "autonomys"
      docker-tag         = "taurus-2025-may-27"
      reserved-only      = false
      prune              = false
      genesis-hash       = "295aeafca762a304d92ee1505548695091f6082d3f0aa4d092ac3cd6397a6c5e"
      dsn-listen-port    = 30533
      node-dsn-port      = 30433
      operator-port      = 30334
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    bootstrap-node-autoid-config = {
      instance-type      = var.instance_type["autoid_bootstrap"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["autoid_bootstrap"]
      docker-org         = "autonomys"
      docker-tag         = "taurus-2025-may-27"
      reserved-only      = false
      prune              = false
      genesis-hash       = "295aeafca762a304d92ee1505548695091f6082d3f0aa4d092ac3cd6397a6c5e"
      dsn-listen-port    = 30533
      node-dsn-port      = 30433
      operator-port      = 30334
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    rpc-indexer-node-config = {
      instance-type      = var.instance_type["rpc-indexer"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["rpc-indexer"]
      docker-org         = "autonomys"
      docker-tag         = "taurus-2025-may-27"
      domain-prefix      = "rpc-indexer"
      reserved-only      = false
      prune              = false
      node-dsn-port      = 30433
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    nova-indexer-node-config = {
      instance-type      = var.instance_type["nova-indexer"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["nova-indexer"]
      docker-org         = "autonomys"
      docker-tag         = "taurus-2025-may-27"
      domain-prefix      = "auto-evm-indexer"
      reserved-only      = false
      prune              = false
      node-dsn-port      = 30433
      enable-domains     = true
      domain-id          = var.domain_id
      domain-labels      = var.domain_labels
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    rpc-node-config = {
      instance-type      = var.instance_type["rpc"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["rpc"]
      docker-org         = "autonomys"
      docker-tag         = "taurus-2025-may-27"
      domain-prefix      = "rpc"
      reserved-only      = false
      prune              = false
      node-dsn-port      = 30433
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    domain-node-config = {
      instance-type      = var.instance_type["domain"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["domain"]
      docker-org         = "autonomys"
      docker-tag         = "taurus-2025-may-27"
      domain-prefix      = ["auto-evm", "autoid"]
      reserved-only      = false
      prune              = false
      node-dsn-port      = 30433
      enable-domains     = true
      domain-id          = var.domain_id
      domain-labels      = var.domain_labels
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    farmer-node-config = {
      instance-type          = var.instance_type["farmer"]
      deployment-version     = 0
      regions                = var.aws_region
      instance-count         = var.instance_count["farmer"]
      docker-org             = "autonomys"
      docker-tag             = "taurus-2025-may-27"

    @github-actions
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Centralize docker tag value

    Consolidate the repeated hardcoded tag into a single Terraform local or variable to
    avoid duplication and simplify future updates. Replace each direct string with a
    reference to that local/variable.

    resources/terraform/taurus/main.tf [13]

    -docker-tag         = "taurus-2025-may-27"
    +docker-tag         = local.taurus_docker_tag
    Suggestion importance[1-10]: 6

    __

    Why: The repeated hardcoded docker-tag values can be consolidated into a single variable (e.g., local.taurus_docker_tag) to improve maintainability and simplify future updates.

    Low

    @DaMandal0rian DaMandal0rian requested a review from vedhavyas May 27, 2025 10:06
    @DaMandal0rian DaMandal0rian merged commit c446176 into main May 27, 2025
    1 check passed
    @DaMandal0rian DaMandal0rian deleted the chore/taurus-upgrade branch May 27, 2025 10:51
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants