-
Notifications
You must be signed in to change notification settings - Fork 39
Update icons, splash screen and about images #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
nazar-pc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also appreciate for images to be optimized (I usually just use optipng CLI tool), right now all images are 100-120% larger than their previous version, which is hard to attribute just to changed image alone.
I'd prefer Taurus and custom icons to be added right away. For .png files they should be with .taurus and .custom suffix, so icon.taurus.png. For space-acres.ico and space-acres.icns add taurus and custom icons as second and third in the same file (they are containers that supports multiple icons at once). Not sure if macOS will allow to change it in runtime, but I'll look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented on Slack, this is a logo, not "about" image. Note that icons were optimized for readability and this one had a larger view. It'd be nice to keep it that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we crop to the tractor for the icon, the "T" and "C" variants will have the lettering overlap the tractor. Is an overlap acceptable or should we leave them off the icon and just use the colour shift to represent the chain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think tractor is already large enough and occupies most of the space. It should be a completely separate picture, might not even include the same tractor at all, it is just something that I did to save time for myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this updated about image feel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sides of the tractor on about.png look really wrong
|
@jim-counter is there an ETA on when "about" image might be ready? I don't want this to hang unmerged for too long. |
An updated design is in the works. I don't have an ETA but it is still being worked on. |
|
Looking forward to it. I saw some demand for farming on Taurus recently and would like to land support for it in Space Acres right after these resources are ready. |
Any guidance on optimisation options? using |
|
I literally used no options, just |
Update icons, splash screen and about images.
Once the changes are confirmed good there will be a follow up PR to add Taurus and custom chain specific assets.