Check no-std/std and other missing features in CI #3427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
requested review from
NingLin-P,
nazar-pc and
vedhavyas
as code owners
vedhavyas
reviewed
Mar 11, 2025
| restore-keys: | | ||
| ${{ runner.os }}-cargo- | ||
| - name: cargo build --locked --package subspace-runtime |
Contributor
There was a problem hiding this comment.
Some descriptive name please. Easier to see the flow
| - name: cargo build --locked --package subspace-runtime | ||
| run: | | ||
| cargo -Zgitoxide -Zgit build --locked --package subspace-runtime |
Contributor
There was a problem hiding this comment.
why not build all the packages at once ?
Contributor
Author
There was a problem hiding this comment.
Because cargo does feature unification, which hides missing features:
https://doc.rust-lang.org/cargo/reference/features.html#feature-unification
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to PR #3426, which makes sure that:
This will avoid future issues like those fixed in PR #3426.
Code contributor checklist: