Revert "Backport Proof of Space perf improvements from abundance" #3722
Conversation
teor2345
added
bug
🛡️ Immunefi PR ReviewsWe noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below: Once submitted, we'll take care of assigning a reviewer and follow up here. |
|
I talked to Jeremy about this, we're thinking of doing a revert to get the stack overflow fix out. @vedhavyas what do you think? |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| }); | ||
|
|
||
| let (sector, plotted_sector, table_generator) = plotting_result_receiver.await.unwrap(); | ||
| let (sector, plotted_sector, mut table_generator) = plotting_result_receiver.await.unwrap(); |
There was a problem hiding this comment.
Bug: Mutable borrow break after trait change
The variable table_generator was declared as mutable on line 153 (let (sector, plotted_sector, mut table_generator) = plotting_result_receiver.await.unwrap();), but the trait TableGenerator::generate() now requires a mutable reference after the revert (changed from &self to &mut self in the trait definition). However, the code on line 189 calls table_generator.generate_parallel(seed) which also requires &mut self. Since table_generator is captured by the closure on line 189 and used multiple times, this will cause compilation errors due to multiple mutable borrows. The generate_parallel method signature was changed from taking &self to &mut self, which breaks the closure's ability to call it multiple times.
There was a problem hiding this comment.
Hallucination, there are no compilation errors.
|
Yeah, we can revert and pick it up later |
Reverts #3712 because it contained some unexpected incompatible changes.