Skip to content

Conversation

@vedhavyas
Copy link
Contributor

@vedhavyas vedhavyas commented Dec 8, 2025

Migrate from stable2412 to stable 2503 latest. Our fork is updated accordingly with necessary patches applied on top.
Some of the patches can be pushed upstream and will send a patch once I'm finished with migration.

PR aims to avoid behavior change as much as possible. New features are not included if not straightforward and maybe added in follow-up PRs

Changes

  • Major is coming from scale-codec with DecodeWithMemTracking marker trait that needs to be added to our types that cross the runtime boundary to client.
  • Frontier added a new host function ProofSize which it uses to get the measure proof size of the ext rather than an estimation unlike before. More here polkadot-evm/frontier@d5755b5
  • Network start is no more required
  • New utility calls and multisig calls and benchmarking them was required.
  • New if_else utility call is added where ext contain default Call and Fallback back if default fails. This would be tricky to handle for object mapping and left a TODO for later PRs
  • You will now see a warning when compiling Runtime to migrate to wasm32v1-none. I did not want to take migration to new target yet until we are the sure the rest of the upgrade is compatible.

TODOs

  • Ensure tests are not failing
  • Tests both Consensus and Domain locally
  • Ensure no migrations
  • Devnet
    • Deploy with previous release and old runtime
    • Check Client compatibility
    • Check Runtime compatibility through runtime upgrade
      • Consensus Runtime Is Compatible with old clients without Domains
      • EVM domain runtime is NOT compatible with old clients due to the host function and all the nodes will have to migrate to new Node. Consensus clients also needs to migrate due to fraud proof verification and fails on missing host functions
  • Test Client on Chronos
  • Test Client on Mainnnet

I'm leaving this PR as draft until Devnet TODO is complete but please do review in the meantime

Migration plan is listed here - https://www.notion.so/subspacelabs/Stable-2503-2cc0bae47e9580cd9642ca225d91797c

Code contributor checklist:

@vedhavyas vedhavyas requested a review from nazar-pc as a code owner December 8, 2025 06:33
@immunefi-magnus
Copy link

🛡️ Immunefi PR Reviews

We noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below:

🔗 Send this PR in for review

Once submitted, we'll take care of assigning a reviewer and follow up here.

@vedhavyas vedhavyas marked this pull request as draft December 8, 2025 06:33
@vedhavyas vedhavyas marked this pull request as ready for review December 9, 2025 10:05
@vedhavyas vedhavyas added execution Subspace execution breaking-runtime This PR introduces breaking changes to the runtime breaking-node This PR introduces breaking changes to the node implementation labels Dec 9, 2025
0xjeremyfrank
0xjeremyfrank previously approved these changes Dec 16, 2025
Copy link
Contributor

@0xjeremyfrank 0xjeremyfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we add the detailed mainnet deployment strategy to the PR description?

@vedhavyas vedhavyas added this pull request to the merge queue Dec 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2025
@vedhavyas
Copy link
Contributor Author

@jfrank-summit need another review. Recent farmerless dev changes are now included and fixed the RPC provider that was failing in the merge-queue

@vedhavyas vedhavyas added this pull request to the merge queue Dec 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2025
@vedhavyas vedhavyas added this pull request to the merge queue Dec 17, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2025
@vedhavyas vedhavyas added this pull request to the merge queue Dec 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2025
@vedhavyas vedhavyas merged commit 238cf0e into main Dec 19, 2025
16 checks passed
@vedhavyas vedhavyas deleted the stable2503 branch December 19, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-node This PR introduces breaking changes to the node implementation breaking-runtime This PR introduces breaking changes to the runtime execution Subspace execution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants