Logitech f710 config and minor fixes #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Device selection assumes that the search term from yaml file is fully lower-case. It fails to recognise the device if for e.g we specify "Nintendo" instead of "nintendo". Fix this trivial bug by converting the search string to lower-case before matching to evdev.list_devices(). Signed-off-by: Jithu Joseph <[email protected]>
People tend to duplicate this file to add newer controllers. The code in part.py looks for the key "joystick_max_value" and not "joystic_max_value", and fallback to Nintendo's default fallback value which is hard-coded in the code 1280. Signed-off-by: Jithu Joseph <[email protected]>
Logitech F710 joystick uses a dongle for wireless connectivity. Hence it can be used with boards which doesn't have bluetooth buitin like Nvidia JetSon Nano for e.g. While this part is (wrongly) named bluetooth_game_controller, it works over any game controllers which expose /dev/input/event* device files. Signed-off-by: Jithu Joseph <[email protected]>
The D-pad buttons in Logitech F710 events identify as event.type == ecodes.EV_ABS. Consequently the current code in read_loop() tends to scale it. Map the throttle scaling to two other buttons which report as regular buttons, so that the current throttle scaling logic works correctly. Signed-off-by: Jithu Joseph <[email protected]>
When the user starts the script with log cli option, it displays the
key presses to the console. This info is helpful in knowing the
key-mappings for a new controller.
However some details like maximum and minimum values for absolute
axes are missing. Displaying capabilities will help resolve this.
Here is a snippet from this:
...
{('EV_ABS', 3): [(('ABS_X', 0),
AbsInfo(value=-386, min=-32768, max=32767, fuzz=16, flat=128, resolution=0)),
...
Signed-off-by: Jithu Joseph <[email protected]>
Also added benchmark section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series does the following: