Migration dest vm cleanup refactor #6766
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add optional destination VM backup/cleanup functionality to MigrationBase: - New parameter 'do_destination_vm_backup' (default: no) to enable feature - Accept optional remote_virsh session for destination host operations - Check if VM exists on destination before migration - Fail test if destination VM is running (blocker condition) - Backup and undefine pre-existing stopped VMs to avoid conflicts - Use comprehensive undefine options (--nvram, --managed-save, etc.) - Restore destination VM in cleanup_default() Update migration_iommu_device test: - Add setup_remote_virsh_session() helper function - Create single remote virsh session shared across test operations - Refactor check_iommu_xml() to reuse remote session (no duplication) - Add cleanup_default() call in finally block - Properly close remote session in finally block This allows migration tests to run on non-clean environments without depending on destination host state. AI assisted code and commit. Human reviewed. Signed-off-by: hholoubk <[email protected]> migration: refactor base_steps connection params Refactor MigrationBase to cache destination host credentials and reuse them across methods, and extract destination VM backup/undefine flow into a helper method. AI assisted code and commit. Human reviewed. Signed-off-by: hholoubk <[email protected]> migration: restore pre-existing destination VM from backup When do_destination_vm_backup is enabled, include destination host info in logs, fail with clearer message if the destination VM is running, and restore a backed-up destination VM by copying its XML file to the destination host before defining it via remote virsh. AI assisted code and commit. Human reviewed. Signed-off-by: hholoubk <[email protected]> migration: skip undefine when destination VM is absent When destination VM backup is enabled, return early if the VM does not exist on the destination host, and enable debug logging for the existence/running-state checks. AI assisted code and commit. Human reviewed. Signed-off-by: hholoubk <[email protected]>
hholoubk
force-pushed
the
migration_dest_vm_cleanup_refactor
branch
from
206b810 to
8d86f36
Compare
Only call destination VM backup/undefine helper when do_destination_vm_backup is enabled, and drop the redundant guard from the helper. AI assisted code and commit. Human reviewed. Signed-off-by: hholoubk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.