Skip to content

Conversation

@hholoubk
Copy link
Contributor

@hholoubk hholoubk commented Jan 19, 2026

Move migration_source_uri to top-level configuration to ensure it's always available when migrate_vm_back is enabled by CI overrides. This prevents the test from defaulting to qemu:///system (local host) during migration-back operations.

Changes:

  • Add top-level migration_source_uri = "qemu+ssh://${client_ip}/system"
  • Remove 4 redundant per-variant definitions in bi_directional cases

Resolves: LTF-823

AI assisted code and commit. Human reviewed.

Summary by CodeRabbit

  • Chores
    • Refactored VM migration configuration by consolidating source URI settings to global scope, eliminating duplicate parameters from nested sections for simplified configuration management.

✏️ Tip: You can customize this high-level summary in your review settings.

Move migration_source_uri to top-level configuration to ensure it's
always available when migrate_vm_back is enabled by CI overrides.
This prevents the test from defaulting to qemu:///system (local host)
during migration-back operations.

Changes:
- Add top-level migration_source_uri = "qemu+ssh://${client_ip}/system"
- Remove 4 redundant per-variant definitions in bi_directional cases

Resolves: LTF-823

AI assisted code and commit. Human reviewed.
Signed-off-by: hholoubk <[email protected]>
@hholoubk hholoubk marked this pull request as ready for review January 19, 2026 07:26
@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

Walkthrough

This change consolidates the migration_source_uri configuration parameter from multiple nested configuration blocks into a single top-level global setting in the migration test configuration file. The parameter was previously defined in several nested locations under various migration scenarios (bi_directional blocks within p2p_migration and tunnelled_migration, as well as migration-with-nbd, gluster, and rdma sections) and is now centralized at the top level, eliminating duplication across four separate locations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: moving migration_source_uri to top-level config to fix bi-directional migration tests, which directly addresses the changeset's primary objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant