Skip to content

Conversation

@smitterl
Copy link
Contributor

@smitterl smitterl commented Jan 19, 2026

No HyperV on s390x, disable.

Summary by CodeRabbit

  • Tests
    • VM test configuration updated to explicitly exclude the s390-virtio variant for the VM with Hyper-V scenario.
    • This narrows executed test variants for that scenario, reducing irrelevant platform coverage during those tests.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

Walkthrough

A single configuration line "no s390-virtio" was added to libvirt/tests/cfg/cpu/vm_with_hyperv.cfg, excluding the s390-virtio variant from that VM's configuration. This is a configuration-only change; no code, API signatures, or functional implementation were modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'vm_with_hyperv: disable for s390x' accurately describes the main change: disabling the vm_with_hyperv configuration for s390x architecture due to lack of HyperV support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

No HyperV on s390x, disable.

Signed-off-by: Sebastian Mitterle <[email protected]>
@smitterl smitterl force-pushed the disable_hyperv_s390x branch from f44618a to eaebfa7 Compare January 19, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant