Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtio_fs: use dd cmd to create file #3916

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

xiagao
Copy link
Contributor

@xiagao xiagao commented Dec 18, 2023

Echo cmd sometimes cause timeout issue in automation, and the main test point isn't create files in this case, so using dd cmd to instead of echo cmd.
ID: 1752

@xiagao
Copy link
Contributor Author

xiagao commented Jan 10, 2024

@leidwang Could you review this patch?

@leidwang
Copy link
Contributor

leidwang commented Jan 10, 2024

Could you add the test results here, thanks!
Btw, if it is a workaround, maybe we can add an annotation here.

@leidwang
Copy link
Contributor

Hi @xiagao

Any update about this PR?Thanks.

@xiagao
Copy link
Contributor Author

xiagao commented Feb 28, 2024

Test result is passed,but update to github failed last time.

Copy link
Contributor

@leidwang leidwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xiagao
Copy link
Contributor Author

xiagao commented Mar 4, 2024

@YongxueHong Could you please have a look at this patch? Thanks.

@YongxueHong
Copy link
Contributor

Hi @xiagao
As you mentioned Echo cmd sometimes cause timeout issue in automation....
Would you like to explain the reason for it? What's the root cause that results in the timeout issue?
Thanks.

@xiagao
Copy link
Contributor Author

xiagao commented Mar 4, 2024

Hi @xiagao As you mentioned Echo cmd sometimes cause timeout issue in automation.... Would you like to explain the reason for it? What's the root cause that results in the timeout issue? Thanks.

Hi yongxue, actually I didn't know the root cause, so I use a workaround here to test the main test point.

@YongxueHong
Copy link
Contributor

Hi @xiagao As you mentioned Echo cmd sometimes cause timeout issue in automation.... Would you like to explain the reason for it? What's the root cause that results in the timeout issue? Thanks.

Hi yongxue, actually I didn't know the root cause, so I use a workaround here to test the main test point.

Got it, but I am afraid that your currency solution will hit the same issue since we did not find the root cause just use another command which is the same as the previous way(echo command).
IOM, I don't think that the currency way is a workaround, A workaround is a concept that describes a short-term or temporary solution to a problem that we already know the root cause for it.
Thanks.

@xiagao
Copy link
Contributor Author

xiagao commented Mar 4, 2024

Hi @xiagao As you mentioned Echo cmd sometimes cause timeout issue in automation.... Would you like to explain the reason for it? What's the root cause that results in the timeout issue? Thanks.

Hi yongxue, actually I didn't know the root cause, so I use a workaround here to test the main test point.

Got it, but I am afraid that your currency solution will hit the same issue since we did not find the root cause just use another command which is the same as the previous way(echo command). IOM, I don't think that the currency way is a workaround, A workaround is a concept that describes a short-term or temporary solution to a problem that we already know the root cause for it. Thanks.

I know your concern, actually in many test loops, "echo xx" cmd always failed, but "dd xx" cmd passed. And "echo xx" would passed manually.
Anyway, I think your concern makes sense, give me some time to figure out the precise root cause.

Echo cmd sometimes cause timeout issue in automation,
and the main test point isn't create files in this case, so
using dd cmd to instead of echo cmd.

Signed-off-by: Xiaoling Gao <[email protected]>
@xiagao xiagao marked this pull request as ready for review August 15, 2024 06:38
@YongxueHong
Copy link
Contributor

Hi @xiagao
Based on your analysis, indeed this is an automation issue, it is not related to the product, and not to block the test case, let's merge it first.
BTW, Could you help to open an issue to track the root automation bug?
I would like to fix it if I am free in the future.
Thanks.

Copy link
Contributor

@YongxueHong YongxueHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@YongxueHong YongxueHong merged commit 050920b into autotest:master Sep 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants