-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtio_fs: use dd cmd to create file #3916
Conversation
5e76313
to
e128cac
Compare
@leidwang Could you review this patch? |
Could you add the test results here, thanks! |
Hi @xiagao Any update about this PR?Thanks. |
Test result is passed,but update to github failed last time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@YongxueHong Could you please have a look at this patch? Thanks. |
Hi @xiagao |
Hi yongxue, actually I didn't know the root cause, so I use a workaround here to test the main test point. |
Got it, but I am afraid that your currency solution will hit the same issue since we did not find the root cause just use another command which is the same as the previous way( |
I know your concern, actually in many test loops, "echo xx" cmd always failed, but "dd xx" cmd passed. And "echo xx" would passed manually. |
e128cac
to
fbe5553
Compare
Echo cmd sometimes cause timeout issue in automation, and the main test point isn't create files in this case, so using dd cmd to instead of echo cmd. Signed-off-by: Xiaoling Gao <[email protected]>
fbe5553
to
da82314
Compare
Hi @xiagao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Echo cmd sometimes cause timeout issue in automation, and the main test point isn't create files in this case, so using dd cmd to instead of echo cmd.
ID: 1752