Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

block_resize:fix miss sgdisk and disk hardcode #4092

Merged
merged 1 commit into from
Jul 29, 2024
Merged

block_resize:fix miss sgdisk and disk hardcode #4092

merged 1 commit into from
Jul 29, 2024

Conversation

qingwangrh
Copy link
Contributor

1.The guest does not always deploy sgdisk first.
It need to check sgdisk cmd in advance.
2.It should not use hardcode sdb as data disk

ID:2572,2571

@qingwangrh
Copy link
Contributor Author

python ConfigTest.py --testcase=block_resize.with_iozone.with_data_disk.fmt_qcow2.with_gpt_ext4 --guestname=RHEL.10.0 --firmware=default_bios --clone=no
(1/1) Host_RHEL.m9.u5.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.block_resize.with_iozone.with_data_disk.fmt_qcow2.with_gpt_ext4.q35: STARTED
(1/1) Host_RHEL.m9.u5.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.block_resize.with_iozone.with_data_disk.fmt_qcow2.with_gpt_ext4.q35: PASS (137.95 s)

@qingwangrh
Copy link
Contributor Author

@XueqiangWei @fbq815 Please help to review , thanks.

XueqiangWei
XueqiangWei approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@XueqiangWei XueqiangWei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Acked-by: [email protected]

@XueqiangWei
Copy link
Contributor

XueqiangWei commented Jul 10, 2024 •
edited
Loading

@fbq815 Can you help take a look at it? Many thanks.

@fbq815
Copy link
Contributor

fbq815 commented Jul 26, 2024

LGTM
(1/4)qemu.block_resize.with_iozone.with_data_disk.fmt_qcow2.with_gpt_ext4.s390-virtio: PASS (94.61 s)
(2/4) qemu.block_resize.with_iozone.with_data_disk.fmt_qcow2.with_gpt_xfs.s390-virtio: PASS (84.81 s)
qemu.block_resize.with_iozone.with_data_disk.fmt_raw.with_gpt_ext4.s390-virtio: PASS (87.14 s)
qemu.block_resize.with_iozone.with_data_disk.fmt_raw.with_gpt_xfs.s390-virtio: PASS (85.40 s)
RESULTS : PASS 4 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

@qingwangrh
block_resize:fix miss sgdisk and disk hardcode
f966395 
1.The guest does not always deploy sgdisk first.
  It need to check sgdisk cmd in advance.
2.It should not use hardcode sdb as data disk

Signed-off-by: qingwangrh <[email protected]>
@qingwangrh qingwangrh changed the title block_resize:fix sgdisk in rhel10 and disk hardcode block_resize:fix miss sgdisk and disk hardcode Jul 29, 2024
@XueqiangWei XueqiangWei merged commit 994bc3f into autotest:master Jul 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbq815 fbq815 fbq815 approved these changes

@XueqiangWei XueqiangWei XueqiangWei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qingwangrh @XueqiangWei @fbq815