Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPU:add stream installation way for leapp tool #4113

Merged
merged 1 commit into from
Oct 18, 2024
Merged

IPU:add stream installation way for leapp tool #4113

merged 1 commit into from
Oct 18, 2024
+4 −1

Conversation

MiriamDeng
Copy link
Contributor

ID:2634

Provide installing particular packages for leapp tool

@MiriamDeng
Copy link
Contributor Author

@PaulYuuu @fbq815 could you please to review this patch ?

PaulYuuu
PaulYuuu requested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@PaulYuuu PaulYuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the code flexible with less hard code, and don't provide internal info. cc @lijinlijin

@MiriamDeng
Copy link
Contributor Author

Thanks @PaulYuuu will move the parameter to the internal cfg.

@MiriamDeng
Copy link
Contributor Author

Test results
(1/1) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.x86_64.io-github-autotest-qemu.in_place_upgrade.without_rhsm_rhel8_to_rhel9.stream_install.q35: STARTED
(1/1) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.x86_64.io-github-autotest-qemu.in_place_upgrade.without_rhsm_rhel8_to_rhel9.stream_install.q35: PASS (2772.47 s)

@MiriamDeng
Copy link
Contributor Author

@fbq815 could you also help to review this patch ?

PaulYuuu
PaulYuuu reviewed Jul 30, 2024
View reviewed changes
qemu/tests/cfg/in_place_upgrade.cfg
@@ -53,6 +53,8 @@
- compose_install:
com_install = "yes"
com_ins_leapp = "yum install leapp-upgrade -y"
- stream_install:
# Please modify the build in the internal cfg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should add an example rather than point to internal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@MiriamDeng MiriamDeng force-pushed the stream_install branch 2 times, most recently from 48f9979 to 5e23f7b Compare August 13, 2024 06:02
@MiriamDeng
Copy link
Contributor Author

Updated. Can you help to review it ? Thank you !

@fbq815
Copy link
Contributor

fbq815 commented Sep 23, 2024

seems there's some issue need to be handle, log is paste in the jira ticket

@MiriamDeng
Copy link
Contributor Author

The issue mentioned by Boqiao, it's a known leapp product issue and I've upgrade related information to ID:2641

@MiriamDeng
Copy link
Contributor Author

Hi @fbq815 ,
I refined the patch and please also apply the following ones at the same time.
#4170
https://xxx/1348
Thanks.

@MiriamDeng
Copy link
Contributor Author

I shared the test results from s390x
(1/2) Host_RHEL.m10.u0.nographic.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.s390x.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.s390-virtio: STARTED
(1/2) Host_RHEL.m10.u0.nographic.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.s390x.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.s390-virtio: PASS (1317.47 s)
(2/2) Host_RHEL.m10.u0.nographic.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.s390x.io-github-autotest-qemu.in_place_upgrade.without_rhsm_rhel8_to_rhel9.stream_install.s390-virtio: STARTED
(2/2) Host_RHEL.m10.u0.nographic.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.s390x.io-github-autotest-qemu.in_place_upgrade.without_rhsm_rhel8_to_rhel9.stream_install.s390-virtio: PASS (887.90 s)

fbq815
fbq815 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@fbq815 fbq815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the test result and discuss offline, aprove this MR

@MiriamDeng
Copy link
Contributor Author

I've added the "verifie"d in the commit part, thanks.

@PaulYuuu PaulYuuu merged commit d5093fb into autotest:master Oct 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbq815 fbq815 fbq815 approved these changes

@PaulYuuu PaulYuuu PaulYuuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiriamDeng @fbq815 @PaulYuuu