Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iommufd case for vfio_net_boot #4163

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

fanchen2
Copy link
Contributor

iommufd-backed VFIO, for example:
-object iommufd,id=iommufd0
-device vfio-pci,host=01:00.0,iommufd=iommufd0
Multiple pcie device can use the same iommufd.

Copy link

@xhao22 xhao22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see it covers both VFIO legacy backend and IOMMFD backend for Qemu vfio-pci device.

@PaulYuuu
Copy link
Contributor

Hello @fanchen2, thank you for the PR. I see avocado-framework/avocado-vt#4004, will help to review both.

Cc @JinLiul, as you may also be interesting with this.

PaulYuuu
PaulYuuu previously approved these changes Oct 22, 2024
Copy link
Contributor

@PaulYuuu PaulYuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's wait for the avocado-vt patch to be merged, then we can merge this one.

Also, thank you for your contribution.

@PaulYuuu
Copy link
Contributor

PaulYuuu commented Nov 8, 2024

Hello @fanchen2, I will merge this PR once all CI checks succeed. But some tips for you:

  1. Do not use master as the branch to contribute.
  2. tp-qemu requires gpg-signed commit.
  3. tp-qemu supports to use pre-commit to format code locally.

Thank you for the first contribution.

@PaulYuuu
Copy link
Contributor

PaulYuuu commented Nov 8, 2024

@fanchen2 btw, can you provide test results?

@fanchen2
Copy link
Contributor Author

fanchen2 commented Nov 8, 2024

@PaulYuuu Yes, yes, thank you.
I just found the branch issue, I closed it by mistake, sorry to reopen.
This is the test result for single PF, only one NIC device available on my system for testing now, is that OK?

[root@emr-120485 ~]# avocado run --vt-config /root/avocado/data/avocado-vt/backends/qemu/cfg/nic.cfg
JOB ID : c6f480c845cc848a081cf4b29b7159202e11745f
JOB LOG : /root/avocado/job-results/job-2024-11-08T16.55-c6f480c/job.log
(1/1) type_specific.myprovider.vfio_net_boot.default.default.iommufd.ipv4.pf.one_nic.single_vm: STARTED
(1/1) type_specific.myprovider.vfio_net_boot.default.default.iommufd.ipv4.pf.one_nic.single_vm: PASS (54.11 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB TIME : 55.11 s
[root@emr-120485 ~]# avocado run --vt-config /root/avocado/data/avocado-vt/backends/qemu/cfg/nic.cfg
JOB ID : bc496010345039068cc6d39e7d555548f1eda58c
JOB LOG : /root/avocado/job-results/job-2024-11-08T16.58-bc49601/job.log
(1/1) type_specific.myprovider.vfio_net_boot.default.default.multi_iommufd.ipv4.pf.one_nic.single_vm: STARTED
(1/1) type_specific.myprovider.vfio_net_boot.default.default.multi_iommufd.ipv4.pf.one_nic.single_vm: PASS (54.26 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB TIME : 55.23 s

@PaulYuuu PaulYuuu merged commit 1f08acc into autotest:master Nov 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants