Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtio_fs_localfs_migration: Migrate localfs with different cache modes #4184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhencliu
Copy link
Contributor

@zhencliu zhencliu commented Oct 25, 2024

ID: 2967

@zhencliu zhencliu force-pushed the virtiofs_migration_localfs branch 10 times, most recently from 70593da to 7eb9f47 Compare October 29, 2024 02:55
@zhencliu
Copy link
Contributor Author

hi @hellohellenmao , would you please review this patch? I am not sure if this patch meet your expectation, I just follow Your palorion case's steps

@zhencliu zhencliu force-pushed the virtiofs_migration_localfs branch 3 times, most recently from b8d9be4 to 54bce23 Compare October 29, 2024 14:37
@zhencliu
Copy link
Contributor Author

hi @hellohellenmao , would you please review it again? All test metrix was covered IMO, thanks.

The following testing matrix is covered:
cache mode:
auto, never, always, metadata
writeback:
enabled and disabled
allow-direct-io
enabled and disabled
fs:
single fs and two fs

Single node migration, with different localfs.

@zhencliu
Copy link
Contributor Author

Testing Win2022 and RHEL9.3 guest OS, all passed

@zhencliu zhencliu force-pushed the virtiofs_migration_localfs branch 3 times, most recently from 1662e04 to 2a44523 Compare October 29, 2024 23:15
@hellohellenmao
Copy link
Contributor

@xiagao Could you please help to take a review from windows perspective?

@xiagao
Copy link
Contributor

xiagao commented Nov 4, 2024

@xiagao Could you please help to take a review from windows perspective?

Sure, will work on it after other tasks on hand.

@hellohellenmao
Copy link
Contributor

@fbq815 Could you please help to review here? Thanks.

fs_driver = virtio-fs
fs_source_type = mount
fs_source_dir_fs = /var/tmp/virtio_fs_source
fs_source_dir_targetfs = /var/tmp/virtio_fs_target
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing to confirm with @hellohellenmao :
The migration happened on two nodes and the systemdisk is located in NFS server, is that correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO systemdisk is not a problem as we are doing single node migration, the fs exported is the key

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Then it's okay for single node migration.

The following testing matrix is covered:
cache mode:
  auto, never, always, metadata
writeback:
  enabled and disabled
allow-direct-io
  enabled and disabled
fs:
  single fs and two fs

Signed-off-by: Zhenchao Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants