-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtio_fs_localfs_migration: Migrate localfs with different cache modes #4184
base: master
Are you sure you want to change the base?
Conversation
70593da
to
7eb9f47
Compare
hi @hellohellenmao , would you please review this patch? I am not sure if this patch meet your expectation, I just follow Your palorion case's steps |
b8d9be4
to
54bce23
Compare
hi @hellohellenmao , would you please review it again? All test metrix was covered IMO, thanks. The following testing matrix is covered: Single node migration, with different localfs. |
Testing Win2022 and RHEL9.3 guest OS, all passed |
1662e04
to
2a44523
Compare
@xiagao Could you please help to take a review from windows perspective? |
Sure, will work on it after other tasks on hand. |
@fbq815 Could you please help to review here? Thanks. |
2a44523
to
44f08b6
Compare
fs_driver = virtio-fs | ||
fs_source_type = mount | ||
fs_source_dir_fs = /var/tmp/virtio_fs_source | ||
fs_source_dir_targetfs = /var/tmp/virtio_fs_target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing to confirm with @hellohellenmao :
The migration happened on two nodes and the systemdisk is located in NFS server, is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO systemdisk is not a problem as we are doing single node migration, the fs exported is the key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense. Then it's okay for single node migration.
The following testing matrix is covered: cache mode: auto, never, always, metadata writeback: enabled and disabled allow-direct-io enabled and disabled fs: single fs and two fs Signed-off-by: Zhenchao Liu <[email protected]>
44f08b6
to
550fa74
Compare
ID: 2967