storage_volume: set direct=on for image_aio=native #4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliang123
force-pushed
the
2919
branch
5 times, most recently
from
0807404
to
1301624
Compare
|
(1/1) Host_RHEL.m9.ux.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.x.0.x86_64.io-github-autotest-qemu.blockdev_snapshot_stop_cont.q35: PASS (89.72 s) |
|
@zhencliu @XueqiangWei and @maxujun , please help review it, thanks. |
zhencliu
reviewed
Nov 7, 2024
zhencliu
approved these changes
Nov 7, 2024
XueqiangWei
approved these changes
Nov 7, 2024
|
@maxujun Could you please help take a look at it? Many thanks. |
(1/1) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.blockdev_snapshot_stop_cont: STARTED LGTM，Acked. |
|
hi @aliang123 , would you please do a rebase? Then we can merge this patch |
When setting image_aio to native, cache.direct:on is required. Signed-off-by: Aihua Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting image_aio to native, cache.direct:on
is required.
id: 2919