Skip to content

dump_guest_core: fix nonexistent qemu-kvm-debuginfo package #4310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heywji
Copy link
Contributor

@heywji heywji commented May 16, 2025

The script previously attempted to install a "qemu-kvm-debuginfo" RPM package, which does not exist. As a result, running dnf -y install qemu-kvm-debuginfo fails with "Unable to find a match" and aborts the script.

ID: 3867

Signed-off-by: Wenkang Ji [email protected]

@heywji heywji changed the title dump_guest_core: fix qemu-kvm-core debuginfo installed dump_guest_core: add qemu-kvm-core debuginfo installed May 16, 2025
@leidwang
Copy link
Contributor

Hi @heywji Is this parch ready for review?

@heywji
Copy link
Contributor Author

heywji commented May 27, 2025

@leidwang Hi, yes. We need it for our fwcfg feature. Please help review it as well.

@leidwang
Copy link
Contributor

It would be better to introduce more about why we install this package?Such like what will happen if not install it? And why we did not need it before.

@heywji
Copy link
Contributor Author

heywji commented May 27, 2025

Let me turn to the draft first, and then I will add more notes on the patch description to explain why we need this package.

@heywji heywji marked this pull request as draft May 27, 2025 02:42
@heywji heywji changed the title dump_guest_core: add qemu-kvm-core debuginfo installed dump_guest_core: fix nonexistent qemu-kvm-debuginfo package May 27, 2025
@heywji heywji marked this pull request as ready for review May 27, 2025 05:29
@heywji
Copy link
Contributor Author

heywji commented May 27, 2025

@leidwang Hi, Leidong. I have added some explanation here and changed the code. Could you help review it now?

@leidwang
Copy link
Contributor

@leidwang Hi, Leidong. I have added some explanation here and changed the code. Could you help review it now?

Okay, I saw you updated the code and description, it is clear now. Please add the test results of the latest code.

@heywji
Copy link
Contributor Author

heywji commented May 27, 2025

Test Result:

 (1/2) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.1.x86_64.io-github-autotest-qemu.dump_guest_core.on.q35: STARTED
 (1/2) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.1.x86_64.io-github-autotest-qemu.dump_guest_core.on.q35: PASS (413.16 s)
 (2/2) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.1.x86_64.io-github-autotest-qemu.dump_guest_core.off.q35: STARTED
 (2/2) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.1.x86_64.io-github-autotest-qemu.dump_guest_core.off.q35: PASS (383.54 s)

@PaulYuuu
Copy link
Contributor

Please use the right way(dnf debuginfo-install) to install debuginfo package.

@heywji
Copy link
Contributor Author

heywji commented May 27, 2025

@PaulYuuu OK, I will rewrite the logic to replace the utils_package.package_install(packages) function.

@heywji heywji force-pushed the KVMAUTOMA-3867 branch 2 times, most recently from 9b1aa68 to 17649a4 Compare June 24, 2025 04:33
@heywji
Copy link
Contributor Author

heywji commented Jun 24, 2025

Test Result: pass

Test log:

L0662 INFO | Running 'rpm -q crash'
L0475 DEBUG| [stdout] crash-9.0.0-1.el9.x86_64
L0719 INFO | Command 'rpm -q crash' finished with 0 after 0.008072031s
L0662 INFO | Running 'rpm -q gdb'
L0475 DEBUG| [stdout] gdb-14.2-4.1.el9_6.x86_64
L0719 INFO | Command 'rpm -q gdb' finished with 0 after 0.006525636s
L0662 INFO | Running 'debuginfo-install -y kernel qemu-kvm qemu-kvm-core'
L0475 DEBUG| [stdout] Updating Subscription Management repositories.
L0475 DEBUG| [stdout] Unable to read consumer identity
L0475 DEBUG| [stdout]
L0475 DEBUG| [stdout] This system is not registered with an entitlement server. You can use "rhc" or "subscription-manager" to register.
L0475 DEBUG| [stdout]
L0475 DEBUG| [stdout] enabling epel-debuginfo repository
L0475 DEBUG| [stdout] enabling epel-cisco-openh264-debuginfo repository
L0475 DEBUG| [stdout] Extra Packages for Enterprise Linux 9 - x86_64  1.5 MB/s | 7.3 MB     00:04
L0475 DEBUG| [stdout] Extra Packages for Enterprise Linux 9 openh264  1.1 kB/s | 3.6 kB     00:03
L0475 DEBUG| [stdout] Could not find debugsource package for the following installed packages: kernel-5.14.0-590.el9.x86_64
L0475 DEBUG| [stdout] Dependencies resolved.
L0475 DEBUG| [stdout] Nothing to do.
L0475 DEBUG| [stdout] Complete!
L0719 INFO | Command 'debuginfo-install -y kernel qemu-kvm qemu-kvm-core' finished with 0 after 11.188088372s

@heywji
Copy link
Contributor Author

heywji commented Jun 24, 2025

Hi @leidwang @PaulYuuu

Please review this patch when you have some free time. Thanks a lot!

The script previously attempted to install a "qemu-kvm-debuginfo" RPM
package, which does not exist. As a result, running `dnf -y install
qemu-kvm-debuginfo` fails with "Unable to find a match" and aborts the
script.

Signed-off-by: Wenkang Ji [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants