-
Notifications
You must be signed in to change notification settings - Fork 180
dump_guest_core: fix nonexistent qemu-kvm-debuginfo package #4310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @heywji Is this parch ready for review? |
@leidwang Hi, yes. We need it for our fwcfg feature. Please help review it as well. |
It would be better to introduce more about why we install this package?Such like what will happen if not install it? And why we did not need it before. |
Let me turn to the draft first, and then I will add more notes on the patch description to explain why we need this package. |
@leidwang Hi, Leidong. I have added some explanation here and changed the code. Could you help review it now? |
Okay, I saw you updated the code and description, it is clear now. Please add the test results of the latest code. |
Test Result:
|
Please use the right way( |
@PaulYuuu OK, I will rewrite the logic to replace the |
9b1aa68
to
17649a4
Compare
Test Result: pass Test log:
|
The script previously attempted to install a "qemu-kvm-debuginfo" RPM package, which does not exist. As a result, running `dnf -y install qemu-kvm-debuginfo` fails with "Unable to find a match" and aborts the script. Signed-off-by: Wenkang Ji [email protected]
The script previously attempted to install a "qemu-kvm-debuginfo" RPM package, which does not exist. As a result, running
dnf -y install qemu-kvm-debuginfo
fails with "Unable to find a match" and aborts the script.ID: 3867
Signed-off-by: Wenkang Ji [email protected]