Skip to content

fwcfg: fix windbg install check and move fwcfg dmp file path #4316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

heywji
Copy link
Contributor

@heywji heywji commented May 28, 2025

This MR includes two commit changes: fix windbg install check and move fwcfg dmp file path, AND relocate the large fwcfg-generated .dmp file to avoid filling the system disk during our virtio-win-acceptance tests.

ID: 3920

Signed-off-by: wji [email protected]

@heywji heywji force-pushed the fix_fwcfg_windbg branch from 318ccd9 to 544c137 Compare June 3, 2025 05:41
@heywji
Copy link
Contributor Author

heywji commented Jun 3, 2025

@leidwang @xiagao Hi Leidong and Xiaoling, could you guys please help me review this patch? The purpose is to make the Windbg setup process more precise and replace the DMP file.

@heywji heywji force-pushed the fix_fwcfg_windbg branch 6 times, most recently from 873d1fe to 112060b Compare June 6, 2025 08:12
@heywji
Copy link
Contributor Author

heywji commented Jun 6, 2025

Modified all test cfg files related to the windbg_install_cmd argument.

@heywji heywji marked this pull request as draft June 10, 2025 06:30
@heywji heywji force-pushed the fix_fwcfg_windbg branch 4 times, most recently from 52986ba to 7edc5f3 Compare June 16, 2025 10:07
@heywji heywji marked this pull request as ready for review June 16, 2025 10:16
@heywji heywji force-pushed the fix_fwcfg_windbg branch 2 times, most recently from 28a5b52 to 8517d63 Compare June 19, 2025 04:41
@heywji
Copy link
Contributor Author

heywji commented Jun 19, 2025

Test result:

 (1/5) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.fwcfg.q35:  PASS (1500.75 s)
 (2/5) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.fwcfg.q35: STARTED
 (2/5) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.fwcfg.q35:  FAIL: windbg tool has not been installed (1445.99 s)
 (3/5) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.fwcfg.q35: STARTED
 (3/5) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.fwcfg.q35:  FAIL: windbg tool has not been installed (1406.47 s)
 (4/5) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.fwcfg.q35: STARTED
 (4/5) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.fwcfg.q35:  PASS (1570.46 s)
 (5/5) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.fwcfg.q35: STARTED
 (5/5) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.fwcfg.q35:  FAIL: Check dump file failed, output as Opened log file 'C:\\dump_analyze.log'\nNo .natvis files found at C:\Windows\SYSTEM32\Visualizers.\nNo .natvis fil
es found at C:\Users\Administrator\AppData\Local\Dbg\Visualizers.\n\nMicrosoft (R) Windows Debugger Version 10.... (1578.05 s)```

@heywji
Copy link
Contributor Author

heywji commented Jun 23, 2025

After discussing this problem with @leidwang offline, I realized the best method to fix it is to install it using a Windbg offline software package. I will upload the last code about it, but our Winutils server is broken and waiting for recovery.
Please do not merge it. We must wait for our Winutils server to return it.

@heywji heywji force-pushed the fix_fwcfg_windbg branch 3 times, most recently from 5871551 to 24a7926 Compare June 23, 2025 06:44
@heywji
Copy link
Contributor Author

heywji commented Jun 23, 2025

Hi @leidwang, could you help review this patch?

Test Result:

 (1/4) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.fwcfg.q35:  PASS (406.41 s)
 (2/4) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.fwcfg.q35: STARTED
 (2/4) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.fwcfg.q35:  PASS (422.81 s)
 (3/4) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.fwcfg.q35: STARTED
 (3/4) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.fwcfg.q35:  PASS (515.80 s)
 (4/4) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.fwcfg.q35: STARTED
 (4/4) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.fwcfg.q35:  PASS (442.67 s)
RESULTS    : PASS 4 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0```

@heywji heywji force-pushed the fix_fwcfg_windbg branch from 24a7926 to 29202cb Compare July 1, 2025 02:37
@heywji heywji force-pushed the fix_fwcfg_windbg branch from 29202cb to ac7191e Compare July 1, 2025 03:18
Switch fwcfg installation from the web-based WinSDKSetup to the
stand-alone WinDbg offline installer.

Signed-off-by: wji <[email protected]>
@heywji heywji force-pushed the fix_fwcfg_windbg branch from ac7191e to 8be93ac Compare July 1, 2025 07:07
@heywji
Copy link
Contributor Author

heywji commented Jul 1, 2025

Test result: pass

CaseName                                 Status          StartTime       EndTime         Result     TimeElapsed
01-Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.single_driver_install.with_fwcfg.virtio_win_iso_media.q35 Finshed 2025-07-01 03:10:43 2025-07-01 03:16:15 PASS 332.133477
02-Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.disable_win_update.q35 Finshed 2025-07-01 03:16:15 2025-07-01 03:19:01 PASS 165.251391
03-Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.fwcfg.q35 Finshed 2025-07-01 03:19:01 2025-07-01 03:41:51 PASS 1370.060511
04-Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.fwcfg_enable.with_shutdown.q35 Finshed 2025-07-01 03:41:52 2025-07-01 04:06:48 PASS 1496.029663
05-Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.fwcfg_enable.with_reboot.q35 Finshed 2025-07-01 04:06:48 2025-07-01 04:32:28 PASS 1539.86825
06-Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.fwcfg_enable.with_system_reset.q35 Finshed 2025-07-01 04:32:29 2025-07-01 04:58:02 PASS 1533.701028
07-Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.fwcfg_enable.with_live_migration.q35 Finshed 2025-07-01 04:58:03 2025-07-01 05:23:46 PASS 1542.76771
08-Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.win_virtio_driver_update_test.with_fwcfg.before_bg_test.uninstall_install.q35 Finshed 2025-07-01 05:23:46 2025-07-01 05:53:03 PASS 1756.206467
09-Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.windows_info.q35 Finshed 2025-07-01 05:53:03 2025-07-01 05:54:52 PASS 109.239317
10-Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.qemu_img_check.q35 Finshed 2025-07-01 05:54:53 2025-07-01 05:54:56 PASS 3.635824
Summary:
Finshed=10, PASS=10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants