-
Notifications
You must be signed in to change notification settings - Fork 180
fwcfg: fix windbg install check and move fwcfg dmp file path #4316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
873d1fe
to
112060b
Compare
Modified all test cfg files related to the windbg_install_cmd argument. |
52986ba
to
7edc5f3
Compare
28a5b52
to
8517d63
Compare
Test result:
|
After discussing this problem with @leidwang offline, I realized the best method to fix it is to install it using a Windbg offline software package. I will upload the last code about it, but our Winutils server is broken and waiting for recovery. |
5871551
to
24a7926
Compare
Hi @leidwang, could you help review this patch? Test Result:
|
Signed-off-by: wji <[email protected]>
Switch fwcfg installation from the web-based WinSDKSetup to the stand-alone WinDbg offline installer. Signed-off-by: wji <[email protected]>
Test result: pass
|
This MR includes two commit changes: fix windbg install check and move fwcfg dmp file path, AND relocate the large fwcfg-generated .dmp file to avoid filling the system disk during our virtio-win-acceptance tests.
ID: 3920
Signed-off-by: wji [email protected]