Skip to content

Conversation

@qingwangrh
Copy link
Contributor

@qingwangrh qingwangrh commented Dec 16, 2025

ID: 4776, 4777, 4778, 4779, 4780, 4781, 4782

Summary by CodeRabbit

  • Tests
    • Updated multiple test configuration files to enable boot-related behavior across block device and storage test scenarios.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: qingwangrh <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Dec 16, 2025

Walkthrough

This pull request adds the configuration parameter image_boot = yes to seven QEMU test configuration files: block_4k_discard.cfg, block_check_memory_leak.cfg, block_iothread_test.cfg, block_iscsi_with_specical_max_sectors.cfg, throttle_block_set_io_throttle.cfg, vdpa_sim_blk_test.cfg, and virtio_aer_opt.cfg. The addition is consistent across all files with no modifications to existing parameters.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Homogeneous, repetitive changes across multiple configuration files
  • Single line additions with no logic modifications
  • Pure configuration parameter assignments with consistent pattern application

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix cases boot issues' directly relates to the changeset, which adds image_boot = yes configuration to multiple test files to fix boot-related problems.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@qingwangrh
Copy link
Contributor Author

python ConfigTest.py --testcase=virtio_aer_opt,block_check_memory_leak.with_pass_through.with_block,block_iscsi_with_specical_max_sectors,block_iothread_test.with_cfg.legacy_cfg,block_4k_discard.with_hd,throttle_block_set_io_throttle,vdpa_sim_blk_test.multi_disks --iothread_scheme=full:3 --nr_iothreads=2 --platform=x86_64 --guestname=RHEL.9.8 --driveformat=virtio_blk --imageformat=qcow2 --machines=q35 --customsparams="vm_mem_limit = 12G" --firmware=default_bios --netdst=virbr0 --clone=no

(1/7) Host_RHEL.m9.u8.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.8.0.x86_64.io-github-autotest-qemu.vdpa_sim_blk_test.multi_disks.q35: STARTED
(1/7) Host_RHEL.m9.u8.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.8.0.x86_64.io-github-autotest-qemu.vdpa_sim_blk_test.multi_disks.q35: PASS (43.42 s)
(2/7) Host_RHEL.m9.u8.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.8.0.x86_64.io-github-autotest-qemu.throttle_block_set_io_throttle.q35: STARTED
(2/7) Host_RHEL.m9.u8.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.8.0.x86_64.io-github-autotest-qemu.throttle_block_set_io_throttle.q35: PASS (100.47 s)
(3/7) Host_RHEL.m9.u8.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.8.0.x86_64.io-github-autotest-qemu.virtio_aer_opt.q35: STARTED
(3/7) Host_RHEL.m9.u8.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.8.0.x86_64.io-github-autotest-qemu.virtio_aer_opt.q35: PASS (45.60 s)
(4/7) Host_RHEL.m9.u8.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.8.0.x86_64.io-github-autotest-qemu.block_check_memory_leak.with_pass_through.with_block.q35: STARTED
(4/7) Host_RHEL.m9.u8.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.8.0.x86_64.io-github-autotest-qemu.block_check_memory_leak.with_pass_through.with_block.q35: PASS (235.47 s)
(5/7) Host_RHEL.m9.u8.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.8.0.x86_64.io-github-autotest-qemu.block_4k_discard.with_hd.q35: STARTED
(5/7) Host_RHEL.m9.u8.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.8.0.x86_64.io-github-autotest-qemu.block_4k_discard.with_hd.q35: PASS (99.65 s)
(6/7) Host_RHEL.m9.u8.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.8.0.x86_64.io-github-autotest-qemu.block_iothread_test.with_cfg.legacy_cfg.q35: STARTED
(6/7) Host_RHEL.m9.u8.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.8.0.x86_64.io-github-autotest-qemu.block_iothread_test.with_cfg.legacy_cfg.q35: PASS (55.87 s)
(7/7) Host_RHEL.m9.u8.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.8.0.x86_64.io-github-autotest-qemu.block_iscsi_with_specical_max_sectors.q35: STARTED
(7/7) Host_RHEL.m9.u8.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.8.0.x86_64.io-github-autotest-qemu.block_iscsi_with_specical_max_sectors.q35: PASS (682.02 s)
RESULTS : PASS 7 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

@qingwangrh
Copy link
Contributor Author

qingwangrh commented Dec 17, 2025

@XueqiangWei @fbq815 Please help to review. thanks

@XueqiangWei
Copy link
Contributor

The bootindex will not be added to the virtio_blk device automatically after the new update (commit 9209b9482c984b3da752a2ab90c57a4af6254c0e). In order to avoid boot issue, set image_boot=yes is a solution.

LGTM
Acked-by: [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants